From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95AB6C77B76 for ; Fri, 21 Apr 2023 14:49:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232655AbjDUOt0 (ORCPT ); Fri, 21 Apr 2023 10:49:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232993AbjDUOtX (ORCPT ); Fri, 21 Apr 2023 10:49:23 -0400 Received: from mail-ua1-x92c.google.com (mail-ua1-x92c.google.com [IPv6:2607:f8b0:4864:20::92c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 321AFE5E for ; Fri, 21 Apr 2023 07:49:22 -0700 (PDT) Received: by mail-ua1-x92c.google.com with SMTP id a1e0cc1a2514c-7756904cbabso1163500241.3 for ; Fri, 21 Apr 2023 07:49:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1682088561; x=1684680561; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Busr6qm7YT9dN2ZoieQ5VIQ2S/28WbEFVkn48a2KA8A=; b=PuAbzDPPRqkbpXlKq62HZ2y7U30xfaE5V+YHUXGl+LMOk5OSgfrYsOUT3M+gVCBFI7 SpatDamDQ3qRs3uUM8MvNAhisTPTLo57DJeigaYGF3qO7mSU0I4SfPLbKyfzyavm6f86 5w2lVNlXAbTVxyTc1jOjp2V9LPiyJgoCCfYW6fEjBgrW6EIARRTdE943wZJUwRg9HyYD FZP2xbkjxZ/M8698omKg34rSjQEZ4qUVw0jv1DouIDiaWpWpOgmpE3/IwOpI14Hhc4Jm qvvu4NqJd/RmLJ3kBdsETa3xE74Ohcltc5+coxCa3jS+8Xh6zoFgDnPuX1P+GYWRhAPU LRww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682088561; x=1684680561; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Busr6qm7YT9dN2ZoieQ5VIQ2S/28WbEFVkn48a2KA8A=; b=CGwW3ephVh1NFpLcP5VH5TCGUd04ra0hunxDgzD9aFq15ElnbAbhT/E4rGOqcLgC+z 2lBf+7am6nvcDTRkWvkVyW7SaLZd6NPgIFdudY6WSF7GhDyr55yfJumfiwcaa+bTGLEd +HvIBHjLPBZjuzWCEH+d9qSCppbJbdZO31M/m3YoXPUSwS+DRH4FUBPWZgucyQ4G6TzJ xIips9pWA88oI9rmrKtSEmzdh11HALRwITpz1Q7GelncgI3n4m/wuPzufpa0Lux5HFZF HnQFVFCzkkjbrQabjgYVaZoN/HAaguoVRINYuQv0zkhaeH+BtMuq0wlnSap6aoPVfs1c T9eQ== X-Gm-Message-State: AAQBX9cJ6Q12xBnKbs63Pw+YLuQ98f99f8M5uCTvuxjmjYlM70uiZnf9 Uw04ifZfYwZQfi6Ncw+7qrCxF1NJ/JMAFhLMiu0= X-Google-Smtp-Source: AKy350a/G30TMDV5Uf+o4p5lUbnx+Idhuvq2ocYacNFl+/hgBUWciCE1IHftL8Pe4wxOBdERyOv7qg== X-Received: by 2002:ad4:5f4a:0:b0:5f3:deca:ee3 with SMTP id p10-20020ad45f4a000000b005f3deca0ee3mr10989073qvg.17.1682087965516; Fri, 21 Apr 2023 07:39:25 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-25-194.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.25.194]) by smtp.gmail.com with ESMTPSA id u16-20020a0cf1d0000000b005ef42464646sm1204996qvl.118.2023.04.21.07.39.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Apr 2023 07:39:24 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1pprv2-000k1o-1f; Fri, 21 Apr 2023 11:39:24 -0300 Date: Fri, 21 Apr 2023 11:39:24 -0300 From: Jason Gunthorpe To: "Saleem, Shiraz" Cc: Tejun Heo , "Ismail, Mustafa" , Leon Romanovsky , "linux-rdma@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kernel-team@fb.com" Subject: Re: [PATCH] RDMA/irdma: Drop spurious WQ_UNBOUND from alloc_ordered_workqueue() call Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 21, 2023 at 02:29:06PM +0000, Saleem, Shiraz wrote: > > Subject: [PATCH] RDMA/irdma: Drop spurious WQ_UNBOUND from > > alloc_ordered_workqueue() call > > > > Workqueue is in the process of cleaning up the distinction between unbound > > workqueues w/ @nr_active==1 and ordered workqueues. Explicit > > WQ_UNBOUND isn't needed for alloc_ordered_workqueue() and will trigger a > > warning in the future. Let's remove it. This doesn't cause any functional > > changes. > > > > Signed-off-by: Tejun Heo > > --- > > drivers/infiniband/hw/irdma/hw.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > --- a/drivers/infiniband/hw/irdma/hw.c > > +++ b/drivers/infiniband/hw/irdma/hw.c > > @@ -1901,8 +1901,8 @@ int irdma_ctrl_init_hw(struct irdma_pci_ > > break; > > rf->init_state = CEQ0_CREATED; > > /* Handles processing of CQP completions */ > > - rf->cqp_cmpl_wq = alloc_ordered_workqueue("cqp_cmpl_wq", > > - WQ_HIGHPRI | > > WQ_UNBOUND); > > + rf->cqp_cmpl_wq = > > + alloc_ordered_workqueue("cqp_cmpl_wq", > > WQ_HIGHPRI); > > if (!rf->cqp_cmpl_wq) { > > status = -ENOMEM; > > break; > > Acked-by: Shiraz Saleem Tejun, do you want this in your tree too? Thanks Jason