From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECF11C6FD18 for ; Tue, 25 Apr 2023 05:37:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233299AbjDYFht (ORCPT ); Tue, 25 Apr 2023 01:37:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233296AbjDYFhr (ORCPT ); Tue, 25 Apr 2023 01:37:47 -0400 Received: from 167-179-156-38.a7b39c.syd.nbn.aussiebb.net (167-179-156-38.a7b39c.syd.nbn.aussiebb.net [167.179.156.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0D9583EC; Mon, 24 Apr 2023 22:37:45 -0700 (PDT) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1prBMf-001zo8-Np; Tue, 25 Apr 2023 13:37:23 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Tue, 25 Apr 2023 13:37:22 +0800 Date: Tue, 25 Apr 2023 13:37:22 +0800 From: Herbert Xu To: Danny Tsen Cc: linux-crypto@vger.kernel.org, leitao@debian.org, nayna@linux.ibm.com, appro@cryptogams.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au, ltcgcw@linux.vnet.ibm.com, dtsen@us.ibm.com Subject: Re: [PATCH 2/5] Glue code for optmized Chacha20 implementation for ppc64le. Message-ID: References: <20230424184726.2091-1-dtsen@linux.ibm.com> <20230424184726.2091-3-dtsen@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230424184726.2091-3-dtsen@linux.ibm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 24, 2023 at 02:47:23PM -0400, Danny Tsen wrote: > > +static int __init chacha_p10_init(void) > +{ > + static_branch_enable(&have_p10); > + > + return IS_REACHABLE(CONFIG_CRYPTO_SKCIPHER) ? > + crypto_register_skciphers(algs, ARRAY_SIZE(algs)) : 0; What is this for? The usual way is to select CRYPTO_SKCIPHER rather than have a mysterious failure at run-time. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt