From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3602DC77B61 for ; Tue, 25 Apr 2023 05:44:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233314AbjDYFoo (ORCPT ); Tue, 25 Apr 2023 01:44:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231351AbjDYFom (ORCPT ); Tue, 25 Apr 2023 01:44:42 -0400 Received: from 167-179-156-38.a7b39c.syd.nbn.aussiebb.net (167-179-156-38.a7b39c.syd.nbn.aussiebb.net [167.179.156.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C3A430FE; Mon, 24 Apr 2023 22:44:41 -0700 (PDT) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1prBTZ-001zum-5I; Tue, 25 Apr 2023 13:44:31 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Tue, 25 Apr 2023 13:44:30 +0800 Date: Tue, 25 Apr 2023 13:44:30 +0800 From: Herbert Xu To: Danny Tsen Cc: linux-crypto@vger.kernel.org, leitao@debian.org, nayna@linux.ibm.com, appro@cryptogams.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au, ltcgcw@linux.vnet.ibm.com, dtsen@us.ibm.com Subject: Re: [PATCH 4/5] Glue code for optmized Poly1305 implementation for ppc64le. Message-ID: References: <20230424184726.2091-1-dtsen@linux.ibm.com> <20230424184726.2091-5-dtsen@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230424184726.2091-5-dtsen@linux.ibm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 24, 2023 at 02:47:25PM -0400, Danny Tsen wrote: > > + if (likely(srclen >= POLY1305_BLOCK_SIZE)) { > + bytes = round_down(srclen, POLY1305_BLOCK_SIZE); > + used = crypto_poly1305_setdctxkey(dctx, src, bytes); > + if (likely(used)) { > + srclen -= used; > + src += used; > + } > + if (srclen >= POLY1305_BLOCK_SIZE*4) { > + vsx_begin(); Your chacha code has a SIMD-fallback, how come this one doesn't? Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt