From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF262C7618E for ; Wed, 26 Apr 2023 15:27:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241300AbjDZP1Z (ORCPT ); Wed, 26 Apr 2023 11:27:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234002AbjDZP1W (ORCPT ); Wed, 26 Apr 2023 11:27:22 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D4C02707; Wed, 26 Apr 2023 08:27:21 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D86A521A17; Wed, 26 Apr 2023 15:27:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1682522839; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PxTXn2BTS1MgLfa6uUxx1IJIGot7tRzMX6mJKeRAOU0=; b=QDiaNXkKB3uTdY6B9oH8hNNCSYV+uqkT4a1892oDrK572lszPhfddPLLMre1CgTN3Dsf5G ScrUsE1jjfCCS9RdneK3ReDxQPcYS0UeDH/7UrhHe7/jwYuQBWILAIQmwaaDfjMZvTqx/I Ekl+fSwPwceAjY3EN+9UF9Yv5eHU6lw= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AF9B5138F0; Wed, 26 Apr 2023 15:27:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id YNWXKNdCSWRPBAAAMHmgww (envelope-from ); Wed, 26 Apr 2023 15:27:19 +0000 Date: Wed, 26 Apr 2023 17:27:19 +0200 From: Michal Hocko To: Yosry Ahmed Cc: Johannes Weiner , Roman Gushchin , Shakeel Butt , Andrew Morton , Muchun Song , Sergey Senozhatsky , Steven Rostedt , Petr Mladek , Chris Li , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] memcg: dump memory.stat during cgroup OOM for v1 Message-ID: References: <20230426133919.1342942-1-yosryahmed@google.com> <20230426133919.1342942-3-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230426133919.1342942-3-yosryahmed@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 26-04-23 13:39:19, Yosry Ahmed wrote: > Commit c8713d0b2312 ("mm: memcontrol: dump memory.stat during cgroup > OOM") made sure we dump all the stats in memory.stat during a cgroup > OOM, but it also introduced a slight behavioral change. The code used to > print the non-hierarchical v1 cgroup stats for the entire cgroup > subtree, not it only prints the v2 cgroup stats for the cgroup under > OOM. > > Although v2 stats are a superset of v1 stats, some of them have > different naming. We also lost the non-hierarchical stats for the cgroup > under OOM in v1. Why is that a problem worth solving? It would be also nice to add an example of the oom report before and after the patch. -- Michal Hocko SUSE Labs