From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A93EC77B7F for ; Fri, 28 Apr 2023 09:44:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345647AbjD1JoP (ORCPT ); Fri, 28 Apr 2023 05:44:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229980AbjD1JoO (ORCPT ); Fri, 28 Apr 2023 05:44:14 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 047714497; Fri, 28 Apr 2023 02:44:13 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BA7B521EE2; Fri, 28 Apr 2023 09:44:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1682675051; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fiJTpK/XRgtTp6ZTdBZkBeDGODxz+KV44UNCy4wvN4k=; b=AGa/xCEjEb3qK0MkSqbET4JkZvo2UGTc8z/NuldzPCjYt42vE3dxHHEbB6d5sy76QyDlKB JZvN9n3qMA7C3W9yiQNLWfKs3iEzV/H7hFRrViMiISFVM6/YwbFIvopZPQ3WQxIfW9qSHl k/+k/CJqK0lRhf7+++JDZcpd7axXQv0= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AC0771390E; Fri, 28 Apr 2023 09:44:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id tI34KWuVS2TmHwAAMHmgww (envelope-from ); Fri, 28 Apr 2023 09:44:11 +0000 Date: Fri, 28 Apr 2023 11:44:11 +0200 From: Michal Hocko To: Yosry Ahmed Cc: Johannes Weiner , Roman Gushchin , Shakeel Butt , Andrew Morton , Muchun Song , Sergey Senozhatsky , Steven Rostedt , Petr Mladek , Chris Li , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] memcg: dump memory.stat during cgroup OOM for v1 Message-ID: References: <20230426133919.1342942-1-yosryahmed@google.com> <20230426133919.1342942-3-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 27-04-23 15:12:46, Yosry Ahmed wrote: [...] > However, I still think this change is valuable. Like you mentioned, > the OOM log is not set in stone, but we shouldn't just change it for > no reason. In this case, for cgroup v1 users, the OOM log changed for > no reason beyond a side effect of another patch. Upon upgrading our > kernel we noticed the behavior change. This patch restores the old > behavior without any cost really, and it makes the code a tiny bit > more consistent. Fair enough. Just make sure you go into more details about why this is causing problems/inconveniences. I am slightly worried this might cause problems to other people who would like to have the same report for both v1 and v2 so we should at least have some solid argumetns to revert rather than "it used has changed and we liked it more that way". I personally do not care all that much. It kinda sucks to dump counters that are not tracked or fully tracked in v1 because that can mislead people and that would be a bigger problem from my POV. -- Michal Hocko SUSE Labs