From: "Theodore Ts'o" <tytso@mit.edu>
To: Wu Jianyue <wujianyue000@gmail.com>
Cc: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4: Put inode_operations in inode.c
Date: Fri, 28 Apr 2023 13:59:20 -0400 [thread overview]
Message-ID: <ZEwJeMUM3bxTLx4q@mit.edu> (raw)
In-Reply-To: <20230428133420.6959-1-wujianyue000@gmail.com>
On Fri, Apr 28, 2023 at 09:34:20PM +0800, Wu Jianyue wrote:
> inode_operations is more suitable to put in inode.c,
> instead of file.c, so moved to inode.c.
The inode operations structure for directories is in fs/ext4/namei.c;
the inode operations for symlinks is in fs/ext4/symlink.c. Exactly
where the structure definition is somewhat arbitrary; should it be
where the majority of the functions are defined? Should it be
associated with the file where operations for that inode type are
located? Should it be in the file where the structure is used (which
is actually in two files; fs/ext4/namei.c and fs/ext4/inode.c)?
Moving it is just churn and makes things less consistent, so I don't
think it's worth it to take this patch, sorry.
- Ted
prev parent reply other threads:[~2023-04-28 17:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 13:34 Wu Jianyue
2023-04-28 17:59 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEwJeMUM3bxTLx4q@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wujianyue000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®