From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9AD6C7EE22 for ; Wed, 10 May 2023 08:21:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236188AbjEJIVT (ORCPT ); Wed, 10 May 2023 04:21:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229893AbjEJIVO (ORCPT ); Wed, 10 May 2023 04:21:14 -0400 Received: from bluemchen.kde.org (bluemchen.kde.org [IPv6:2001:470:142:8::100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C77C694 for ; Wed, 10 May 2023 01:21:12 -0700 (PDT) Received: from ugly.fritz.box (localhost [127.0.0.1]) by bluemchen.kde.org (Postfix) with ESMTP id 1972023FB4; Wed, 10 May 2023 04:21:09 -0400 (EDT) Received: by ugly.fritz.box (masqmail 0.3.4, from userid 1000) id 1pwf4O-XGY-00; Wed, 10 May 2023 10:21:08 +0200 Date: Wed, 10 May 2023 10:21:08 +0200 From: Oswald Buddenhagen To: Takashi Iwai Cc: Ivan Orlov , perex@perex.cz, tiwai@suse.com, axboe@kernel.dk, 42.hyeyoo@gmail.com, surenb@google.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [PATCH] ALSA: PCM: Fix codestyle issues in pcm_native.c Message-ID: Mail-Followup-To: Takashi Iwai , Ivan Orlov , perex@perex.cz, tiwai@suse.com, axboe@kernel.dk, 42.hyeyoo@gmail.com, surenb@google.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org References: <20230510072726.435247-1-ivan.orlov0322@gmail.com> <2023051052-recoil-headache-1594@gregkh> <87a5yc626f.wl-tiwai@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <87a5yc626f.wl-tiwai@suse.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 10, 2023 at 10:06:16AM +0200, Takashi Iwai wrote: >Also, if it's only about white space fix or some indent level issues, >that could be rather more noise and disturbs the git change history, >e.g. it makes difficult to find out the real code changes via git >blame, especially it touches a huge amount of lines like this. > >That said, I'm not going to take such "coding style cleanup" patch >blindly. If it's associated with other real fix or enhancement, I'll >happily take it. Otherwise, I'd rather leave it. > a maybe less confusing way to put it would be "do whitespace cleanups only on the lines that contain "real" changes, and maybe in their immediate proximity for consistency". that means that whitespace-only patches are by definition not acceptable. regards