From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6F87C77B7A for ; Thu, 25 May 2023 09:40:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240665AbjEYJkc (ORCPT ); Thu, 25 May 2023 05:40:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240828AbjEYJj4 (ORCPT ); Thu, 25 May 2023 05:39:56 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEC7DA9 for ; Thu, 25 May 2023 02:39:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=VpuaHp/o7Il2YlDzKUSM0hdJY8pqkR5NkWfsD7YnoUo=; b=w/Eh+TLCuq0AR7mLIO7A9SXEhT api7vTY9f/uYb1qQjLYvTx+fwtAa/kVVrlyC634jAdFrpHNw0KlPpzCNfkgGS46H5jFM50IxCXoz0 dRF9mMWQJ+iBtc70LzJ3h8K4PO8Owettk6K8PSgAj5vDd6AGJs07J2HHSoeN+TBoa0lAfcQlpuL0X wxdpYdCgB88QFPnjahz1vqPYTyOYP2a3P402+jmX2ixDvwll9PvVnQ2kf0Y9DpfJ5aeMUglV4rGJs GqvIKXbLBO4AY+JuieWaimRiJFXXYe4RZUfRAIcW3RL+NXaCwUKVSwLY5y78+j5vwQB8hoJwwyKvb N6hoP2aA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q27RY-00GApj-2N; Thu, 25 May 2023 09:39:36 +0000 Date: Thu, 25 May 2023 02:39:36 -0700 From: Christoph Hellwig To: Mariusz Tkaczyk Cc: arnd@arndb.de, andriy.shevchenko@intel.com, linux-kernel@vger.kernel.org, dan.j.williams@intel.com Subject: Re: [PATCH v2 2/2] misc: enclosure: update sysfs api Message-ID: References: <20230524111231.14506-1-mariusz.tkaczyk@linux.intel.com> <20230524111231.14506-3-mariusz.tkaczyk@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230524111231.14506-3-mariusz.tkaczyk@linux.intel.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 24, 2023 at 01:12:31PM +0200, Mariusz Tkaczyk wrote: > Use DEVICE_ATTR RW and RO macros. Update function names accordingly. > No functional changes intended. The subject looks a bit, I'd say something like: "enclosure: use DEVICE_ATTR_RW* macros" instead. The actual changes look good to me: Reviewed-by: Christoph Hellwig