From: Sakari Ailus <sakari.ailus@iki.fi>
To: shravan kumar <shravan.chippa@microchip.com>
Cc: paul.j.murphy@intel.com, daniele.alessandrelli@intel.com,
mchehab@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v13 1/1] media: i2c: imx334: update pixel, hblank and link frequency
Date: Wed, 17 May 2023 17:04:02 +0300 [thread overview]
Message-ID: <ZGTe0ldLYb4QYZGp@valkosipuli.retiisi.eu> (raw)
In-Reply-To: <20230414123311.23923-2-shravan.chippa@microchip.com>
On Fri, Apr 14, 2023 at 06:03:11PM +0530, shravan kumar wrote:
> From: Shravan Chippa <shravan.chippa@microchip.com>
>
> Update pixel_rate and link frequency for 1920x1080@30
> while changing mode.
>
> Update vblank value while changing mode
>
> Add support to handle multiple link frequencies.
>
> Add dummy ctrl cases for pixel_rate and link frequency
> to avoid error while changing the modes dynamically.
>
> Update default link frequency from device tree max link
> frequency value.
>
> Update init_cfg() function to update the link frequency
> menu_skip_mask value.
>
> Suggested-by: Sakari Ailus <sakari.ailus@iki.fi>
> Signed-off-by: Shravan Chippa <shravan.chippa@microchip.com>
Applied with the following diff:
diff --git a/drivers/media/i2c/imx334.c b/drivers/media/i2c/imx334.c
index d4c9986aee597..93fc1716e00a1 100644
--- a/drivers/media/i2c/imx334.c
+++ b/drivers/media/i2c/imx334.c
@@ -118,6 +118,7 @@ struct imx334_mode {
* @vblank: Vertical blanking in lines
* @cur_mode: Pointer to current selected sensor mode
* @mutex: Mutex for serializing sensor controls
+ * @menu_skip_mask: Menu skip mask for link_freq_ctrl
* @cur_code: current selected format code
* @streaming: Flag indicating streaming state
*/
--
Sakari Ailus
prev parent reply other threads:[~2023-05-17 14:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 12:33 [PATCH v13 0/1] media: i2c: imx334: support lower bandwidth mode shravan kumar
2023-04-14 12:33 ` [PATCH v13 1/1] media: i2c: imx334: update pixel, hblank and link frequency shravan kumar
2023-05-17 14:04 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGTe0ldLYb4QYZGp@valkosipuli.retiisi.eu \
--to=sakari.ailus@iki.fi \
--cc=daniele.alessandrelli@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=paul.j.murphy@intel.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shravan.chippa@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®