From: Christoph Hellwig <hch@infradead.org>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Kees Cook <keescook@chromium.org>, Song Liu <song@kernel.org>,
linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org,
"yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH] md/raid5: Convert stripe_head's "dev" to flexible array member
Date: Mon, 22 May 2023 22:54:07 -0700 [thread overview]
Message-ID: <ZGxU/zSGkqGhGWmF@infradead.org> (raw)
In-Reply-To: <229ac866-9710-5dbe-80c4-61498f807662@huaweicloud.com>
On Mon, May 22, 2023 at 07:49:38PM +0800, Yu Kuai wrote:
> Hi, Christoph
>
> 在 2023/05/18 12:27, Christoph Hellwig 写道:
>
> It's not related to this patch, just I think I found a problem while
> reviewing raid5 code, commit e82ed3a4fbb5 ("md/raid6: refactor
> raid5_read_one_chunk") changes the caculation of 'end_sector',
> 'end_sector' is compared to 'rdev->recovery_offset', so it should be
> offset to rdev, but this commit change it to offset to the array.
>
> Perhaps following change will make sense:
Yes, I think it does. Can you send a patch?
next prev parent reply other threads:[~2023-05-23 5:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 23:33 Kees Cook
2023-05-18 4:27 ` Christoph Hellwig
2023-05-22 11:49 ` Yu Kuai
2023-05-23 5:54 ` Christoph Hellwig [this message]
2023-05-23 13:46 ` Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGxU/zSGkqGhGWmF@infradead.org \
--to=hch@infradead.org \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®