From: Christoph Hellwig <hch@infradead.org>
To: Kees Cook <keescook@chromium.org>
Cc: Song Liu <song@kernel.org>, Christoph Hellwig <hch@infradead.org>,
linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2] md/raid5: Convert stripe_head's "dev" to flexible array member
Date: Mon, 22 May 2023 22:55:54 -0700 [thread overview]
Message-ID: <ZGxVatFgD1u1x+5c@infradead.org> (raw)
In-Reply-To: <20230522212114.gonna.589-kees@kernel.org>
On Mon, May 22, 2023 at 02:21:15PM -0700, Kees Cook wrote:
> - } dev[1]; /* allocated with extra space depending of RAID geometry */
> + } dev[]; /* allocated with extra space depending of RAID geometry */
I still think this should be:
/* allocated depending of RAID geometry */
now or dropped entirely, as the extra only made sense when it always
had that magic one.
The actual code changes looks good to me:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2023-05-23 5:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 21:21 Kees Cook
2023-05-23 5:55 ` Christoph Hellwig [this message]
2023-05-23 17:43 ` Song Liu
2023-05-30 23:00 ` Kees Cook
2023-05-30 23:39 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGxVatFgD1u1x+5c@infradead.org \
--to=hch@infradead.org \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®