From: Vinod Koul <vkoul@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org,
Jaswinder Singh <jassisinghbrar@gmail.com>,
Jaswinder Singh <jassi.brar@samsung.com>,
Boojin Kim <boojin.kim@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Russell King <rmk+kernel@arm.linux.org.uk>,
dmaengine@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH] dmaengine: pl330: rename _start to prevent build error
Date: Tue, 23 May 2023 19:38:58 +0530 [thread overview]
Message-ID: <ZGzI+gsYdF6kEHFk@matsya> (raw)
In-Reply-To: <20230523000606.9405-1-rdunlap@infradead.org>
On 22-05-23, 17:06, Randy Dunlap wrote:
> "_start" is used in several arches and proably should be reserved
> for ARCH usage. Using it in a driver for a private symbol can cause
> a build error when it conflicts with ARCH usage of the same symbol.
>
> Therefore rename pl330's "_start" to "_start_thread" so that there
> is no conflict and no build error.
Why not rename to pl330_start or pl330_start_thread to ensure we will
might not conflict ever!
--
~Vinod
next prev parent reply other threads:[~2023-05-23 14:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 0:06 Randy Dunlap
2023-05-23 6:47 ` Conor Dooley
2023-05-23 14:08 ` Vinod Koul [this message]
2023-05-23 15:20 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGzI+gsYdF6kEHFk@matsya \
--to=vkoul@kernel.org \
--cc=boojin.kim@samsung.com \
--cc=dmaengine@vger.kernel.org \
--cc=jassi.brar@samsung.com \
--cc=jassisinghbrar@gmail.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=rdunlap@infradead.org \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®