Re: [PATCH 4.14 00/86] 4.14.316-rc1 review

[Pavel Machek <pavel@denx.de>]

[-- Attachment #1: Type: text/plain, Size: 1373 bytes --]

Hi!

> This is the start of the stable review cycle for the 4.14.316 release.
> There are 86 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.

> Chaitanya Kulkarni <kch@nvidia.com>
>     null_blk: Always check queue mode setting from configfs

This one is in 4.14 and 5.10, but not in 4.19.

> Alain Volmat <avolmat@me.com>
>     phy: st: miphy28lp: use _poll_timeout functions for waits

This is just a cleanup, we don't really need it in stable.

> Arnd Bergmann <arnd@arndb.de>
>     clk: tegra20: fix gcc-7 constant overflow warning

Something went wrong here:

 #define OSC_FREQ_DET_STATUS 0x5c
-#define OSC_FREQ_DET_BUSY (1<<31)
-#define OSC_FREQ_DET_CNT_MASK 0xFFFF
+#define OSC_FREQ_DET_BUSYu (1<<31)
+#define OSC_FREQ_DET_CNT_MASK 0xFFFFu

First, we don't really need u after hex constants. Second, we normally
use upperspace U for this. Third, u should not really be appended to
the constant name.

> Vicki Pfau <vi@endrift.com>
>     Input: xpad - add constants for GIP interface numbers

This is just a cleanup, we don't really need it in stable.

Best regards,
								Pavel

-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]