From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB1F8C77B73 for ; Tue, 30 May 2023 14:26:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231446AbjE3O0r (ORCPT ); Tue, 30 May 2023 10:26:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232486AbjE3O0W (ORCPT ); Tue, 30 May 2023 10:26:22 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9C7210DE; Tue, 30 May 2023 07:25:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 352E862927; Tue, 30 May 2023 14:25:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8FA3EC433EF; Tue, 30 May 2023 14:25:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685456707; bh=+SYa9bhZBDTkyURy2GHBB/vLDr+xUSjpSqvR1WZibas=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f/juyAhcdNjjQ8aklB2nIws+qDmE0bsjg9H0H0+PjK5dDKw5piNsQu0LQFnle03Yl pcEdusnAxxj9dHlTeNkV+iC98Vu5M74hvEWApcEMA+QTNmPyUZIbyQNfrc7e+xci+E jWaEaqX0Nlrj7xc4/zFfss978JpHu7PUqK/OtbzKKIDg63TFtKyAGkSDzBY2haeDQP jSf8irbEX8RfwIQAKd+HVI01bv762Tm27eBTHgv3KZIdZI+xepKeblQg24dCrvM9ar s5SSwE/2T9R0JdfV+kzwUBrZ5UMu7+F3t/CWanLmj/4trn6WjhaqR6/OR7FFPM5Wwy ITn/31eU7zXRQ== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1q40Hd-0007sX-3Z; Tue, 30 May 2023 16:25:09 +0200 Date: Tue, 30 May 2023 16:25:09 +0200 From: Johan Hovold To: Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz Cc: Matthias Kaehlcke , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Johan Hovold Subject: Re: [PATCH 0/2] Bluetooth: fix bdaddr quirks Message-ID: References: <20230424133542.14383-1-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230424133542.14383-1-johan+linaro@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 24, 2023 at 03:35:40PM +0200, Johan Hovold wrote: > These patches fixes a couple of issues with the two bdaddr quirks: > > The first one allows HCI_QUIRK_INVALID_BDADDR to be used with > HCI_QUIRK_NON_PERSISTENT_SETUP. > > The second patch restores the original semantics of the > HCI_QUIRK_USE_BDADDR_PROPERTY so that the controller is marked as > unconfigured when no device address is specified in the devicetree (as > the quirk is documented to work). > > This specifically makes sure that Qualcomm HCI controllers such as > wcn6855 found on the Lenovo X13s are marked as unconfigured until user > space has provided a valid address. > > Long term, the HCI_QUIRK_USE_BDADDR_PROPERTY should probably be dropped > in favour of HCI_QUIRK_INVALID_BDADDR and always checking the devicetree > property. > Johan Hovold (2): > Bluetooth: fix invalid-bdaddr quirk for non-persistent setup > Bluetooth: fix use-bdaddr-property quirk > > net/bluetooth/hci_sync.c | 30 +++++++++++------------------- > 1 file changed, 11 insertions(+), 19 deletions(-) Any further comments to this series, or can this one be merged for 6.5 now? Johan