From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v8 1/1] gpio: add sloppy logic analyzer using polling
Date: Fri, 2 Jun 2023 17:07:14 +0300 [thread overview]
Message-ID: <ZHn3krVTwGp/0YhO@smile.fi.intel.com> (raw)
In-Reply-To: <CAMuHMdWhtVvA4=vh4imMtL+KssybzB57CNcLaNq9oVKkpeS1iA@mail.gmail.com>
On Fri, Jun 02, 2023 at 08:57:36AM +0200, Geert Uytterhoeven wrote:
> On Fri, Jun 2, 2023 at 8:51 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Thu, Jun 1, 2023 at 11:40 PM <andy.shevchenko@gmail.com> wrote:
> > > Tue, Mar 29, 2022 at 11:11:26AM +0200, Wolfram Sang kirjoitti:
...
> > > However, I haven't checked if it's pure theoretical issue with the current code
> > > base of debugfs or a potential problem. Easy fix is to check an error code and
> >
> > I think debugfs_create_dir() can only fail reasonably due to OOM.
>
> Oops, you were talking about NULL, not an error code.
> I don't think that can ever happen.
That's looks correct, I don't see (looking briefly into the fs/debugfs) that
NULL is possible to be returned. Wondering, why the heck we (used to) have
a lot of IS_ERR_OR_NULL() checks.
> And if I did miss something, it would crash when dereferencing a NULL
> pointer in d_really_is_positive() (as called in start_creating())...
I don't see how, but I see a big comment on top of `if (!parent)`.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-06-02 14:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 9:11 [PATCH v8 0/1] gpio: add simple " Wolfram Sang
2022-03-29 9:11 ` [PATCH v8 1/1] gpio: add sloppy " Wolfram Sang
2022-03-30 14:51 ` Andy Shevchenko
2022-05-25 15:07 ` Wolfram Sang
2023-06-01 15:58 ` Andy Shevchenko
2023-06-01 15:59 ` Andy Shevchenko
2023-06-05 6:31 ` Wolfram Sang
2023-06-01 21:39 ` andy.shevchenko
2023-06-02 6:51 ` Geert Uytterhoeven
2023-06-02 6:57 ` Geert Uytterhoeven
2023-06-02 14:07 ` Andy Shevchenko [this message]
2023-06-02 7:40 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHn3krVTwGp/0YhO@smile.fi.intel.com \
--to=andy.shevchenko@gmail.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®