From: Herbert Xu <herbert@gondor.apana.org.au>
To: yangmengfei1394 <yangmengfei1394@phytium.com.cn>
Cc: davem@davemloft.net, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Crypto module : rearrange the default functions of akcipher
Date: Fri, 2 Jun 2023 18:19:40 +0800 [thread overview]
Message-ID: <ZHnCPBjPROACJpDd@gondor.apana.org.au> (raw)
In-Reply-To: <20230522033027.989-1-yangmengfei1394@phytium.com.cn>
On Mon, May 22, 2023 at 11:30:27AM +0800, yangmengfei1394 wrote:
> According to your last email, we rearrange the default functions,
> move the code that sets the default functions from
> crypto_register_akcipher into akcipher_prepare_alg,
> add the set_pub_key function check at the same time.
Why are you adding set_pub_key? Every implementation should
provide this function.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2023-06-02 10:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 7:51 [PATCH] Crypto: Fix one bug when use kernel ecdsa algorithm yangmengfei1394
2023-05-19 8:33 ` Herbert Xu
2023-05-22 3:30 ` [PATCH] Crypto module : rearrange the default functions of akcipher yangmengfei1394
2023-06-02 10:19 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHnCPBjPROACJpDd@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yangmengfei1394@phytium.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®