From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C21B6C7EE29 for ; Wed, 7 Jun 2023 10:16:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238859AbjFGKQT (ORCPT ); Wed, 7 Jun 2023 06:16:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238843AbjFGKQM (ORCPT ); Wed, 7 Jun 2023 06:16:12 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C419C1BD0 for ; Wed, 7 Jun 2023 03:16:08 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4BC0B1FDAE; Wed, 7 Jun 2023 10:16:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1686132967; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OtOZgD95z/IBl7SqKk0BG6TOYMfHhxxJyQnJ1HGyzbM=; b=UldiIttJJHN/rLQo5Q+nk5SR9MQ1ebiuV5HR+bfplwSBDy3eEkESROO/aI426UWBykaMW/ 77G9jOiMKjIxVIVc+EDuXjrq943SMpFUMjQxMceAkyrN8eO6EF6LWVwLEZiF8S01JoAOmS iHaCxXxZb3oyxZW/4XDnafFP+JdFIqM= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3C99713776; Wed, 7 Jun 2023 10:16:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id +uohDudYgGTTeQAAMHmgww (envelope-from ); Wed, 07 Jun 2023 10:16:07 +0000 Date: Wed, 7 Jun 2023 12:16:06 +0200 From: Michal Hocko To: Haifeng Xu Cc: rppt@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/mm_init.c: add debug messsge for dma zone Message-ID: References: <20230607090734.1259-1-haifeng.xu@shopee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230607090734.1259-1-haifeng.xu@shopee.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 07-06-23 09:07:34, Haifeng Xu wrote: > If freesize is less than dma_reserve, print warning message to report > this case. Why? > Signed-off-by: Haifeng Xu > --- > mm/mm_init.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index 232efac9a929..9a9d6a52471c 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -1561,9 +1561,14 @@ static void __init free_area_init_core(struct pglist_data *pgdat) > } > > /* Account for reserved pages */ > - if (j == 0 && freesize > dma_reserve) { > - freesize -= dma_reserve; > - pr_debug(" %s zone: %lu pages reserved\n", zone_names[0], dma_reserve); > + if (j == 0) { > + if (freesize >= dma_reserve) { > + freesize -= dma_reserve; > + pr_debug(" %s zone: %lu pages reserved\n", > + zone_names[0], dma_reserve); > + } else > + pr_warn(" %s zone: %lu reserved pages exceeds freesize %lu\n", > + zone_names[0], dma_reserve, freesize); > } > > if (!is_highmem_idx(j)) > -- > 2.25.1 -- Michal Hocko SUSE Labs