From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F0FDC7EE2F for ; Sun, 11 Jun 2023 20:07:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232059AbjFKUHs (ORCPT ); Sun, 11 Jun 2023 16:07:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232041AbjFKUHq (ORCPT ); Sun, 11 Jun 2023 16:07:46 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D39CE99; Sun, 11 Jun 2023 13:07:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3Frvdbn/oC6N6awyzuk0N+5XMWltEJKTuOjEd/jd21A=; b=P1NwCL+9z1iDjLenb9/8csDYvD Pjd71+iibDfevuvzLA4SEFDLzS1pFcDbTFi/Nvg+8el6dzelQugFIZQ5poPZbj553EzAnHgl/m5e6 lHYC0B9RnsC5szIApaslelLY9rLbne8U0CYqTMJTDzx+DRh6dTGfOPHJxatpBUHF/XxHkSWhQQb2z rR7FW9NDktT/50g2wgqZzx7WoKCH+ehhQk5R7BKmboefRfSYyaFBlVrtqjNFSelvKgNYcx7VQJaJG 7tgLoB3K8j+oI0LSt8bXh//XxSZVhKedpDezwWEWJ/XHnoIIjhIwsPRiESRcdAzmOiDO5a/6xjkra cskvR02A==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1q8RLO-001goP-Q2; Sun, 11 Jun 2023 20:07:22 +0000 Date: Sun, 11 Jun 2023 21:07:22 +0100 From: Matthew Wilcox To: Jonathan Corbet Cc: Bagas Sanjaya , Shaomin Deng , viro@zeniv.linux.org.uk, brauner@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Mao Zhu Subject: Re: [PATCH] fs: Fix comment typo Message-ID: References: <20230611123314.5282-1-dengshaomin@cdjrlc.com> <87edmhok1h.fsf@meer.lwn.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87edmhok1h.fsf@meer.lwn.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 11, 2023 at 01:50:34PM -0600, Jonathan Corbet wrote: > Bagas Sanjaya writes: > > > On Sun, Jun 11, 2023 at 08:33:14AM -0400, Shaomin Deng wrote: > >> From: Mao Zhu > >> > >> Delete duplicated word in comment. > > > > On what function? > > Bagas, do I *really* have to ask you, yet again, to stop nitpicking our > contributors into the ground? It appears I do. So: > > Bagas, *stop* this. It's a typo patch removing an extraneous word. The > changelog is fine. We absolutely do not need you playing changelog cop > and harassing contributors over this kind of thing. Amen. > >> Signed-off-by: Mao Zhu > > > > You're carrying someone else's patch, so besides SoB from original > > author, you need to also have your own SoB. > > This, instead, is a valid problem that needs to be fixed. I mean ... yes, technically, it does. But it's a change that deletes a word in a comment. Honestly, I'd take the patch without any kind of sign-off. It doesn't create any copyright claim, which is the purpose of the DCO.