From: Christoph Hellwig <hch@infradead.org>
To: Ed Tsai <ed.tsai@mediatek.com>
Cc: axboe@kernel.dk, matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, kbusch@kernel.org,
amergnat@baylibre.com, liusong@linux.alibaba.com,
wsd_upstream@mediatek.com, peter.wang@mediatek.com,
stanley.chu@mediatek.com, powen.kao@mediatek.com,
alice.chao@mediatek.com, naomi.chu@mediatek.com,
Chun-Hung.Wu@mediatek.com
Subject: Re: [PATCH v3] blk-mq: check on cpu id when there is only one ctx mapping
Date: Tue, 13 Jun 2023 23:19:02 -0700 [thread overview]
Message-ID: <ZIlb1vrQVwjOT1QV@infradead.org> (raw)
In-Reply-To: <20230614002529.6636-1-ed.tsai@mediatek.com>
This looks fine to me:
Reviewed-by: Christoph Hellwig <hch@lst.de>
> - if (rq->mq_hctx->nr_ctx == 1 ||
> + if ((rq->mq_hctx->nr_ctx == 1 &&
> + rq->mq_ctx->cpu == raw_smp_processor_id()) ||
> rq->cmd_flags & REQ_POLLED)
But please fix the incorrct indentation in the existing code here
please while you're at it (maybe Jens can just fold it in):
if ((rq->mq_hctx->nr_ctx == 1 &&
rq->mq_ctx->cpu == raw_smp_processor_id()) ||
(rq->cmd_flags & REQ_POLLED))
next prev parent reply other threads:[~2023-06-14 6:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 0:25 Ed Tsai
2023-06-14 6:19 ` Christoph Hellwig [this message]
2023-06-14 17:11 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIlb1vrQVwjOT1QV@infradead.org \
--to=hch@infradead.org \
--cc=Chun-Hung.Wu@mediatek.com \
--cc=alice.chao@mediatek.com \
--cc=amergnat@baylibre.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=axboe@kernel.dk \
--cc=ed.tsai@mediatek.com \
--cc=kbusch@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=liusong@linux.alibaba.com \
--cc=matthias.bgg@gmail.com \
--cc=naomi.chu@mediatek.com \
--cc=peter.wang@mediatek.com \
--cc=powen.kao@mediatek.com \
--cc=stanley.chu@mediatek.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®