From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D11BEB64DC for ; Thu, 15 Jun 2023 06:53:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244579AbjFOGxP (ORCPT ); Thu, 15 Jun 2023 02:53:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243941AbjFOGww (ORCPT ); Thu, 15 Jun 2023 02:52:52 -0400 Received: from mail11.truemail.it (mail11.truemail.it [IPv6:2001:4b7e:0:8::81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3A7F4220; Wed, 14 Jun 2023 23:51:11 -0700 (PDT) Received: from francesco-nb.int.toradex.com (31-10-206-125.static.upc.ch [31.10.206.125]) by mail11.truemail.it (Postfix) with ESMTPA id 222CC207A7; Thu, 15 Jun 2023 08:51:09 +0200 (CEST) Date: Thu, 15 Jun 2023 08:51:07 +0200 From: Francesco Dolcini To: Vignesh Raghavendra Cc: Francesco Dolcini , Nishanth Menon , Francesco Dolcini , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/5] arm64: dts: ti: add verdin am62 Message-ID: References: <20230601131332.26877-1-francesco@dolcini.it> <20230601131332.26877-4-francesco@dolcini.it> <62ca6112-0aca-788e-fc9b-8a2c3ce9ba1f@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <62ca6112-0aca-788e-fc9b-8a2c3ce9ba1f@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 15, 2023 at 11:38:00AM +0530, Vignesh Raghavendra wrote: > > > On 01/06/23 18:43, Francesco Dolcini wrote: > > [...] > > > +/* Verdin I2C_1 */ > > +&main_i2c1 { > > + status = "okay"; > > + > > + /* Audio Codec */ > > + nau8822_1a: audio-codec@1a { > > + compatible = "nuvoton,nau8822"; > > + reg = <0x1a>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_i2s1_mclk>; /* Configure AUDIO_EXT_REFCLK1 pin as output */ > > + #sound-dai-cells = <0>; > > + > > + /* POSTDIV4_16FF_MAIN_2_HSDIVOUT8_CLK -> AUDIO_EXT_REFCLK1 */ > > + assigned-clocks = <&k3_clks 157 10>; > > + assigned-clock-parents = <&k3_clks 157 18>; > > + assigned-clock-rates = <25000000>; /* for 48KHz ± 1.7% */ > > + }; > > + > > Oops, this node fails dtbs_check > > make ARCH=arm64 CROSS_COMPILE=$V8_CROSS CHECK_DTBS=y ti/k3-am625-verdin-nonwifi-dev.dtb > > /work/linux/arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-dev.dtb: audio-codec@1a: '#sound-dai-cells', 'assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks' do not match any of the regexes: 'pinctrl-[0-9]+' > From schema: /home/a0132425/workspace/k3-next/Documentation/devicetree/bindings/sound/nuvoton,nau8822.yaml > /work/linux/arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-dev.dtb: audio-codec@1a: 'anyOf' conditional failed, one must be fixed: > 'clocks' is a required property > '#clock-cells' is a required property > From schema: /work/.local/lib/python3.10/site-packages/dtschema/schemas/clock/clock.yaml This properties are needed here, it will not work without. Not the expert on audio codec and sound cards DT binding, but to me this is just the yaml not being correct. Francesco