From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EEE7EB64DB for ; Thu, 15 Jun 2023 14:20:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344404AbjFOOU6 (ORCPT ); Thu, 15 Jun 2023 10:20:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344145AbjFOOUw (ORCPT ); Thu, 15 Jun 2023 10:20:52 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0747026A6 for ; Thu, 15 Jun 2023 07:20:51 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B6F4D22419; Thu, 15 Jun 2023 14:20:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1686838849; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iYNb+3lcXJf+tmIIl6IAONhkS2Go6YZm3aE1o17Tx0A=; b=i6Q6AyW6froqh6nSV3dqpjOES93TieOrn6KNautrpznUQXQknQJXaBvo52jnrGscCDZcQd By/QcC1Qht88TU464BUEvMDSVMN0gcA6j+0rYH0Ztjd0+9qlVUi2r4BdZkl6hpA9T3E4lR k/BcVw+6IDMNQBL96wJiGXclpPkqmXU= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AA1A713A32; Thu, 15 Jun 2023 14:20:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id hODMKEEei2QpcQAAMHmgww (envelope-from ); Thu, 15 Jun 2023 14:20:49 +0000 Date: Thu, 15 Jun 2023 16:20:49 +0200 From: Michal Hocko To: =?utf-8?B?6LS65Lit5Z2k?= Cc: minchan@kernel.org, senozhatsky@chromium.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [External] Re: [RFC PATCH 1/3] zram: charge the compressed RAM to the page's memcgroup Message-ID: References: <20230615034830.1361853-1-hezhongkun.hzk@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 15-06-23 22:13:09, 贺中坤 wrote: > > This is not really answering my question though. memcg under hard limit > > is not really my concern. This is a simpler case. I am not saying it > > doesn't need to get addresses but it is the memcg hard limited case that > > is much more interested. Because your charges are going to fail very > > likely and that would mean that swapout would fail AFAIU. If my > > understanding is wrong then it would really help to describe that case > > much more in the changelog. > > > > OK, Got it. In many cases I have tested, it will not fail because we did > not charge the page directly，but the objects(like slab,compressed page), > for the zspage may be shared by any memcg. That sounds like a broken design to me. -- Michal Hocko SUSE Labs