From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 1DAD8EB64DB
	for <linux-kernel@archiver.kernel.org>; Thu, 15 Jun 2023 18:32:05 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S238765AbjFOScC (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Thu, 15 Jun 2023 14:32:02 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40190 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S233801AbjFOSbt (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 15 Jun 2023 14:31:49 -0400
Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E48653C06
        for <linux-kernel@vger.kernel.org>; Thu, 15 Jun 2023 11:30:43 -0700 (PDT)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
         key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
        (No client certificate requested)
        by dfw.source.kernel.org (Postfix) with ESMTPS id 12E36622FF
        for <linux-kernel@vger.kernel.org>; Thu, 15 Jun 2023 18:30:21 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6CF9C433C8;
        Thu, 15 Jun 2023 18:30:19 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1686853820;
        bh=IWpeb4Kgm1UamkNtsT5+DO7vNDUGgUuD0Dyst6XKCz4=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=iTmnYVDX+9wbjvHsbaVRPyrv7MPXOPRDHzBhk9XOtcxMnlW9qUfRnHR6k5Wt3ToGj
         i0n8EumMCCHjTpq7p2c0CT33nIZnNnjJvinpRpaZEGtYA2OWoE1iFypxj+ksGr2jnh
         YsIvrP6/vk9xb2bPZ+XHmNmZvDCpWdpPBL8vHgNtZ5TUOAYja2UfEE8VsTnx6Dyvpy
         oeuxHmKCgDLYCAPP3PYqtrtlUO8hEexjRAu6Z3FJIH345Jw7DhXeuyl/i0yfnINOY7
         EgDX8QB9/b5KlWReXOCgYvYIBohwpl4MWc8evhDJAhAbZQcDCzUZwYctnAdQaRWn/D
         NOzgh+NknLiJw==
Date:   Thu, 15 Jun 2023 12:30:17 -0600
From:   Keith Busch <kbusch@kernel.org>
To:     Breno Leitao <leitao@debian.org>
Cc:     Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
        Sagi Grimberg <sagi@grimberg.me>, leit@fb.com,
        "open list:NVM EXPRESS DRIVER" <linux-nvme@lists.infradead.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] nvme: Print capabilities changes just once
Message-ID: <ZItYuVb1vKk9qfX/@kbusch-mbp.dhcp.thefacebook.com>
References: <20230615094903.1341683-1-leitao@debian.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230615094903.1341683-1-leitao@debian.org>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 15, 2023 at 02:49:03AM -0700, Breno Leitao wrote:
> This current dev_info() could be very verbose and being printed very
> frequently depending on some userspace application sending some specific
> commands.
> 
> Just print this message once and skip it until the controller resets.
> Use a controller flag (NVME_CTRL_DIRTY_CAPABILITY) to track if the
> capability needs a reset.

Looks good. 

Reviewed-by: Keith Busch <kbusch@kernel.org>