mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Breno Leitao <leitao@debian.org>
To: Andi Kleen <ak@linux.intel.com>
Cc: pawan.kumar.gupta@linux.intel.com, jpoimboe@kernel.org,
	peterz@infradead.org, tglx@linutronix.de, bp@alien8.de,
	leit@fb.com, hpa@zytor.com, x86@kernel.org, mingo@redhat.com,
	dave.hansen@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] x86/bugs: Break down mitigations configurations
Date: Fri, 16 Jun 2023 01:39:22 -0700	[thread overview]
Message-ID: <ZIwfuvaRFNqZyCC7@gmail.com> (raw)
In-Reply-To: <87352shc98.fsf@linux.intel.com>

On Thu, Jun 15, 2023 at 10:21:55AM -0700, Andi Kleen wrote:
> Breno Leitao <leitao@debian.org> writes:
> 
> > There is no way to compile a kernel today with some of the speculative
> > mitigations disabled. Even if the kernel has
> > CONFIG_SPECULATION_MITIGATIONS=n, some Intel mitigations, such as MDS, TAA,
> > MMIO are still enabled and can only be disabled using a kernel parameter.
> >
> > This patchset creates a way to choose what to enable or disable, and,
> > get the mitigations disable if CONFIG_SPECULATION_MITIGATIONS is not
> > set, as the rest of other mitigations.
> >
> > Also, we want to print a warning message letting users know that these
> > mitigations are disabled.
> >
> > This is a follow up to this discussion: https://lkml.org/lkml/2023/6/12/798
> >
> 
> Isn't this all roughly equivalent to CONFIG_CMDLINE="mitigations=..." ?

It is, indeed. But, the main motivation for this patchset it to solve a
consistency problem on our Kconfig. The user would image that all
speculative mitigations would be disabled if he passes
CONFIG_SPECULATION_MITIGATIONS=n, but that is not true. The user needs
something else, such as CONFIG_CMDLINE="mitigations=off" or "mds=off".

This patchset give more consistency to our Kconfig options, and the user
doesn't need to read between the lines.

      reply	other threads:[~2023-06-16  8:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-15 16:44 Breno Leitao
2023-06-15 16:44 ` [PATCH 1/3] x86/bugs: Create an option to disable MDS Breno Leitao
2023-06-15 22:13   ` Pawan Gupta
2023-06-16 11:47     ` Breno Leitao
2023-06-15 16:44 ` [PATCH 2/3] x86/bugs: Create an option to disable TAA Breno Leitao
2023-06-15 16:44 ` [PATCH 3/3] x86/bugs: Create an option to disable MMIO vulnerability Breno Leitao
2023-06-15 16:44 ` [PATCH 0/2] x86/bugs: Break down mitigations configurations Breno Leitao
2023-06-15 16:44 ` [PATCH 1/2] x86/speculation: Disable mitigations if CONFIG says so Breno Leitao
2023-06-15 16:44 ` [PATCH 2/2] x86/speculation: Print error when mitigations are disabled Breno Leitao
2023-06-15 17:21 ` [PATCH 0/2] x86/bugs: Break down mitigations configurations Andi Kleen
2023-06-16  8:39   ` Breno Leitao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZIwfuvaRFNqZyCC7@gmail.com \
    --to=leitao@debian.org \
    --cc=ak@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=jpoimboe@kernel.org \
    --cc=leit@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pawan.kumar.gupta@linux.intel.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome