From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88FA5EB64DA for ; Fri, 16 Jun 2023 14:24:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345392AbjFPOYZ (ORCPT ); Fri, 16 Jun 2023 10:24:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229461AbjFPOYX (ORCPT ); Fri, 16 Jun 2023 10:24:23 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0440730E7; Fri, 16 Jun 2023 07:24:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686925462; x=1718461462; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=oeSczsDxX7dgG1qanbCD5eUTqofXJ4ON1bXoul1eVY8=; b=UsmxdsCdDW4latAvu8eJXLJPvakIuD0OcAiN0dhnrIo+JPs4AFTGzXFm fegacz7EX7Im/f3d8Rq8iAKbRKWjI0O+pB1aUpeh6npfZ2xDnHbcmbtZr HzoeTDezaYMXhskZB9AaIal6pYA9PzPvb4f+TUJkThR59/UgjJPPvJxHe 4Y1HSgGX3SHtsM5VKdaqFX3OjiFIFIJdZCwhGaCmtRi56XsiCt7bNBdCC kvShqAUS4+eirGo2zIgOvd84R9zKj6scVHR6Aqu72IrL/N4yGONpH8Gok PGo7wWwnZgw9+Zn1OWkumGP37rOxLgj+qHGXoj5YPTxRGC1fJ6LRK0Q9I g==; X-IronPort-AV: E=McAfee;i="6600,9927,10742"; a="359232974" X-IronPort-AV: E=Sophos;i="6.00,247,1681196400"; d="scan'208";a="359232974" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2023 07:24:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10742"; a="742689320" X-IronPort-AV: E=Sophos;i="6.00,247,1681196400"; d="scan'208";a="742689320" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga008.jf.intel.com with ESMTP; 16 Jun 2023 07:24:16 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qAAN3-004Iob-2s; Fri, 16 Jun 2023 17:24:13 +0300 Date: Fri, 16 Jun 2023 17:24:13 +0300 From: Andy Shevchenko To: Tomi Valkeinen Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, Luca Ceresoli , Matti Vaittinen , Laurent Pinchart , Sakari Ailus , Wolfram Sang , Rob Herring , Krzysztof Kozlowski , Mauro Carvalho Chehab , Peter Rosin , Liam Girdwood , Mark Brown , Michael Tretter , Hans Verkuil , Mike Pagano , Krzysztof =?utf-8?Q?Ha=C5=82asa?= , Marek Vasut , Satish Nagireddy Subject: Re: [PATCH v14 13/18] media: i2c: ds90ub953: Use v4l2_fwnode_endpoint_parse() Message-ID: References: <20230616135922.442979-1-tomi.valkeinen@ideasonboard.com> <20230616135922.442979-14-tomi.valkeinen@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230616135922.442979-14-tomi.valkeinen@ideasonboard.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 16, 2023 at 04:59:17PM +0300, Tomi Valkeinen wrote: > Use v4l2_fwnode_endpoint_parse() to parse the sink endpoint parameters. > + nlanes = vep.bus.mipi_csi2.num_data_lanes; > I would also drop this blank line now. > - if (ret != 1 && ret != 2 && ret != 4) > + if (nlanes != 1 && nlanes != 2 && nlanes != 4) Isn't the following cleaner? if (!is_power_of_2(nlanes) || nlanes > 4) > return dev_err_probe(dev, -EINVAL, > - "bad number of data-lanes: %d\n", ret); > + "bad number of data-lanes: %d\n", nlanes); -- With Best Regards, Andy Shevchenko