From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 41D8BEB64D9
	for <linux-kernel@archiver.kernel.org>; Thu, 29 Jun 2023 22:22:25 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230447AbjF2WWY (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Thu, 29 Jun 2023 18:22:24 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39586 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229459AbjF2WWW (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 29 Jun 2023 18:22:22 -0400
Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41EAA30F1
        for <linux-kernel@vger.kernel.org>; Thu, 29 Jun 2023 15:22:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type:
        MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=v2HOXN/dFzSq+BbK3zWw9kYyIXCnd6hSDikcfU87RyM=; b=AnyuLJ636jsNN4XpDq8IvYL4+x
        OJsuDYS3ppbJCvM2+I+iY0edrYjoeUMng3zVkMIZeA0OoN/i78ehT16n+SIgDLiIXDGFwt3NclplX
        n8zdmBFlPrKq7NOgVKW0SZr9bLOMdNzSECGZRYXErlnBNu/10h3VGLz1446YoQoA+23Tq4xyDMFmC
        yOlb2NR0CqhLUwvRtTGbyVSNtdRYyOgpQWqCsOrHpefGCU6MdY4dte7GiXGztUOIjj0B408xKX0uD
        qvx43aP/+82jOay7lW/fsEa/D5qjX0pX+9Vyni25Tx8hRRXWPx13sRLeoZ918K/zcrKWDKnmsqxkI
        tvbpbSpg==;
Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux))
        id 1qF01m-002Kfg-2e;
        Thu, 29 Jun 2023 22:22:14 +0000
Date:   Thu, 29 Jun 2023 15:22:14 -0700
From:   Luis Chamberlain <mcgrof@kernel.org>
To:     Matthieu Baerts <matthieu.baerts@tessares.net>
Cc:     Arnd Bergmann <arnd@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
        Peter Zijlstra <peterz@infradead.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Huacai Chen <chenhuacai@kernel.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sysctl: fix unused proc_cap_handler() function warning
Message-ID: <ZJ4EFjIU8VmhFN9c@bombadil.infradead.org>
References: <20230607120857.3621364-1-arnd@kernel.org>
 <29968249-3fce-d53f-4515-1c7b815cd4b4@tessares.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <29968249-3fce-d53f-4515-1c7b815cd4b4@tessares.net>
Sender: Luis Chamberlain <mcgrof@infradead.org>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 29, 2023 at 05:00:42PM +0200, Matthieu Baerts wrote:
> Hi Arnd,
> 
> On 07/06/2023 14:08, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> > 
> > Since usermodehelper_table() is marked static now, we get a
> > warning about it being unused when SYSCTL is disabled:
> > 
> > kernel/umh.c:497:12: error: 'proc_cap_handler' defined but not used [-Werror=unused-function]
> 
> Thank you for the patch!
> 
> We also hit the same issue on our side after today's sync with Linus'
> tree. I confirm this patch fixes the issue.
> 
> Tested-by: Matthieu Baerts <matthieu.baerts@tessares.net>
> 
> I didn't see this patch applied in Luis' sysctl-next branch, do you know
> who is taking care of it?

I'll send a second pull request to Linus now.

> > Just move it inside of the same #ifdef.
> > 
> > Fixes: e6944e3b75df7 ("sysctl: move umh sysctl registration to its own file")
> 
> A small detail: it looks like the SHA has been modified, it should be
> 861dc0b46432 instead of e6944e3b75df7:
> 
> Fixes: 861dc0b46432 ("sysctl: move umh sysctl registration to its own file")

Adjusted, thanks.

 Luis