From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C24EEB64D7 for ; Fri, 30 Jun 2023 09:20:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230385AbjF3JUq (ORCPT ); Fri, 30 Jun 2023 05:20:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232444AbjF3JT6 (ORCPT ); Fri, 30 Jun 2023 05:19:58 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D61B44B1 for ; Fri, 30 Jun 2023 02:19:27 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id CB2422189C; Fri, 30 Jun 2023 09:19:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1688116765; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=j3GEhaNA0apRlT03hhOFTYFrxGOQIyTB0AkaO1T1KQQ=; b=ARtNh02gLnlihH768pnMUpK2PYdehqY6uxev1Di3n+k98cR4mQlmkMzSfkf3LncAmI49wn yiR/DEFowAKXKSBPRK4SlYsJ4QDXZEZXuXh6mflFI9Z219zQoMBDfFrgNLDYLg+XZrjxcY HtN7M5t79qkAs03dyevmiNWIlq5ZOfI= Received: from suse.cz (unknown [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 00B2D2C141; Fri, 30 Jun 2023 09:19:22 +0000 (UTC) Date: Fri, 30 Jun 2023 11:19:22 +0200 From: Petr Mladek To: Douglas Anderson Cc: Andrew Morton , Randy Dunlap , Michael Ellerman , Christophe Leroy , Greg Kroah-Hartman , Haren Myneni , Jilin Yuan , Laurent Dufour , Luis Chamberlain , Nathan Lynch , Nicholas Piggin , Tom Rix , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] powerpc: Include asm/nmi.c in mobility.c for watchdog_hardlockup_set_timeout_pct() Message-ID: References: <20230629124500.1.I55e2f4e7903d686c4484cb23c033c6a9e1a9d4c4@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230629124500.1.I55e2f4e7903d686c4484cb23c033c6a9e1a9d4c4@changeid> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 2023-06-29 12:45:06, Douglas Anderson wrote: > The powerpc/platforms/pseries/mobility.c calls > watchdog_hardlockup_set_timeout_pct(), which is declared in > . We used to automatically get included, but > that changed as of commit 7ca8fe94aa92 ("watchdog/hardlockup: define > HARDLOCKUP_DETECTOR_ARCH"). Let's add the explicit include. > > Reported-by: Randy Dunlap > Closes: https://lore.kernel.org/r/af19b76d-aa4b-6c88-9cac-eae4b2072497@infradead.org > Fixes: 7ca8fe94aa92 ("watchdog/hardlockup: define HARDLOCKUP_DETECTOR_ARCH") > Signed-off-by: Douglas Anderson Thanks for the patch: Reviewed-by: Petr Mladek Best Regards, Petr