From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDE81EB64D9 for ; Mon, 19 Jun 2023 21:21:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229573AbjFSVVB (ORCPT ); Mon, 19 Jun 2023 17:21:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229799AbjFSVUi (ORCPT ); Mon, 19 Jun 2023 17:20:38 -0400 Received: from mail11.truemail.it (mail11.truemail.it [IPv6:2001:4b7e:0:8::81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 594AD10E for ; Mon, 19 Jun 2023 14:20:36 -0700 (PDT) Received: from francesco-nb.int.toradex.com (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id 3AEBE201E6; Mon, 19 Jun 2023 23:20:33 +0200 (CEST) Date: Mon, 19 Jun 2023 23:20:28 +0200 From: Francesco Dolcini To: Nishanth Menon Cc: Santosh Shilimkar , Tero Kristo , Francesco Dolcini , Wadim Egorov , vigneshr@ti.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, d-gole@ti.com Subject: Re: [PATCH] firmware: ti_sci: Use system_state to determine polling Message-ID: References: <20230619131236.3285069-1-nm@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230619131236.3285069-1-nm@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 19, 2023 at 08:12:36AM -0500, Nishanth Menon wrote: > Commit b9e8a7d950ff ("firmware: ti_sci: Switch transport to polled > mode during system suspend") aims to resolve issues with tisci > operations during system suspend operation. However, the system may > enter a no_irq stage in various other usage modes, including power-off > and restart. To determine if polling mode is appropriate, use the > system_state instead. > > While at this, drop the unused is_suspending state variable and > related helpers. > > Reported-by: Francesco Dolcini > Reported-by: Wadim Egorov > Link: https://lore.kernel.org/all/ZGeHMjlnob2GFyHF@francesco-nb.int.toradex.com/ > Signed-off-by: Nishanth Menon s/Link/Closes/ Fixes: b9e8a7d950ff ("firmware: ti_sci: Switch transport to polled mode during system suspend") > drivers/firmware/ti_sci.c | 35 ++--------------------------------- > 1 file changed, 2 insertions(+), 33 deletions(-) > > diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c > index 039d92a595ec..dc7906e38f09 100644 > --- a/drivers/firmware/ti_sci.c > +++ b/drivers/firmware/ti_sci.c ... > -static DEFINE_SIMPLE_DEV_PM_OPS(ti_sci_pm_ops, ti_sci_suspend, ti_sci_resume); You need to stop using ti_sci_pm_ops in ti_sci_driver, without this change it does not build. diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c index dc7906e38f09..91aaa0ca9bde 100644 --- a/drivers/firmware/ti_sci.c +++ b/drivers/firmware/ti_sci.c @@ -3485,7 +3485,6 @@ static struct platform_driver ti_sci_driver = { .driver = { .name = "ti-sci", .of_match_table = of_match_ptr(ti_sci_of_match), - .pm = &ti_sci_pm_ops, }, }; With that change I was able to do a quick test on a patched v6.4-rc7 and it seems to solve the issue. Tested-by: Francesco Dolcini # Toradex Verdin AM62 Francesco