From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 278CFEB64DB for ; Tue, 20 Jun 2023 06:14:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231127AbjFTGOb (ORCPT ); Tue, 20 Jun 2023 02:14:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231130AbjFTGOZ (ORCPT ); Tue, 20 Jun 2023 02:14:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCEAA10F9; Mon, 19 Jun 2023 23:14:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 642C660FD7; Tue, 20 Jun 2023 06:14:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BED06C433C8; Tue, 20 Jun 2023 06:14:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687241661; bh=nrq0IjkxMUy98tG4sKvGO/xFKexns8OJc6XXvAJ5QsU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oA6z3x9pGifLfF2EGZCu+yxLPciOp0BNXT9IivkLP2LxHcseJpuMiK6CBnQUeZOe9 jj4NYHyo8Hml61a6qtKOHTFE/nNvRCe/RsIj13veiALDtkRViWCWfiO1uajIVT4uhi LHAzyMq8OO9OjYmE5KOFCRvcnIkr29gKYMU/j6SRG5Mib7/AKJVwdUGb8trF4rMM08 6LIVqNn6HUGgiof3rBc7XfkmPvYOWqMVghjedCP3aVh/moeqXjEriqtLNtXGP6N2Ws ftUspgQO4bDf7YYcQbThISa+NUlckVowQxy+76e4fuwCSCgOxjU0YjHtL1pXGQeY5h YPKn0SXcOJirQ== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1qBUdA-0006OK-Pw; Tue, 20 Jun 2023 08:14:21 +0200 Date: Tue, 20 Jun 2023 08:14:20 +0200 From: Johan Hovold To: Oliver Neukum Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Kaufmann Automotive GmbH Subject: Re: [PATCH] USB: serial-simple: adding Kaufmann RKS+CAN VCP Message-ID: References: <20230613093351.3383-1-oneukum@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230613093351.3383-1-oneukum@suse.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 13, 2023 at 11:33:51AM +0200, Oliver Neukum wrote: > Adding the device and product ID Can you say something more about the product here (e.g. to indicate that this is indeed a custom firmware that requires a simple driver)? > Reported-by: Kaufmann Automotive GmbH > Tested-by: Kaufmann Automotive GmbH > Signed-off-by: Oliver Neukum > --- > drivers/usb/serial/usb-serial-simple.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/usb/serial/usb-serial-simple.c b/drivers/usb/serial/usb-serial-simple.c > index 4c6747889a19..3612031030bb 100644 > --- a/drivers/usb/serial/usb-serial-simple.c > +++ b/drivers/usb/serial/usb-serial-simple.c > @@ -117,6 +117,11 @@ DEVICE(suunto, SUUNTO_IDS); > { USB_DEVICE(0x908, 0x0004) } > DEVICE(siemens_mpi, SIEMENS_IDS); > > +/* KAUFMANN RKS+CAN VCP */ > +#define KAUFMANN_IDS() \ > + { USB_DEVICE(0x16d0, 0x0870) } > +DEVICE(kaufmann, KAUFMANN_IDS); Can you add this one after GOOGLE_IDS() to approximate some ordering? I'll try to move the rest in place later. > + > /* All of the above structures mushed into two lists */ > static struct usb_serial_driver * const serial_drivers[] = { > &carelink_device, > @@ -133,6 +138,7 @@ static struct usb_serial_driver * const serial_drivers[] = { > &hp4x_device, > &suunto_device, > &siemens_mpi_device, > + &kaufmann_device, > NULL > }; > > @@ -151,6 +157,7 @@ static const struct usb_device_id id_table[] = { > HP4X_IDS(), > SUUNTO_IDS(), > SIEMENS_IDS(), > + KAUFMANN_IDS(), > { }, > }; Similar in these two arrays. Johan