From: Tejun Heo <tj@kernel.org>
To: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.co,
vincent.guittot@linaro.org, linux-kernel@vger.kernel.org,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, bristot@redhat.com,
vschneid@redhat.com, fuyuanli@didiglobal.com, zwp10758@gmail.com,
zyhtheonly@gmail.com, zyhtheonly@yeah.net
Subject: Re: [PATCH v2] sched/isolation: add a workqueue parameter to constrain unbound CPUs
Date: Wed, 21 Jun 2023 10:51:26 -1000 [thread overview]
Message-ID: <ZJNizvI-7A2hFDoM@slm.duckdns.org> (raw)
In-Reply-To: <20230614091923.GA1059@didi-ThinkCentre-M930t-N000>
On Wed, Jun 14, 2023 at 05:19:45PM +0800, tiozhang wrote:
...
> @@ -181,8 +181,8 @@ static int __init housekeeping_nohz_full_setup(char *str)
> {
> unsigned long flags;
>
> - flags = HK_FLAG_TICK | HK_FLAG_WQ | HK_FLAG_TIMER | HK_FLAG_RCU |
> - HK_FLAG_MISC | HK_FLAG_KTHREAD;
> + flags = HK_FLAG_TICK | HK_FLAG_TIMER | HK_FLAG_RCU | HK_FLAG_MISC
> + | HK_FLAG_KTHREAD;
Why is WQ being taken out of nohz_full setup? The patch description doesn't
mention anything.
> @@ -208,6 +208,12 @@ static int __init housekeeping_isolcpus_setup(char *str)
> continue;
> }
>
> + if (!strncmp(str, "workqueue,", 10)) {
> + str += 10;
> + flags |= HK_FLAG_WQ;
> + continue;
> + }
I wonder whether it'd be better to just add a workqueue boot param but if
this works it's fine too.
Thanks.
--
tejun
next prev parent reply other threads:[~2023-06-21 20:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 9:28 [PATCH] " tiozhang
2023-06-14 9:19 ` [PATCH v2] " tiozhang
2023-06-21 20:51 ` Tejun Heo [this message]
2023-06-22 3:22 ` [PATCH v3] sched/isolation: add a workqueue parameter onto isolcpus " tiozhang
2023-06-26 20:54 ` Tejun Heo
2023-06-26 22:59 ` Frederic Weisbecker
2023-06-22 3:47 ` [PATCH v2] sched/isolation: add a workqueue parameter " Yuanhan Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJNizvI-7A2hFDoM@slm.duckdns.org \
--to=tj@kernel.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=fuyuanli@didiglobal.com \
--cc=juri.lelli@redhat.co \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=zwp10758@gmail.com \
--cc=zyhtheonly@gmail.com \
--cc=zyhtheonly@yeah.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®