From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3A7AC001B0 for ; Fri, 23 Jun 2023 08:14:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231861AbjFWIOm (ORCPT ); Fri, 23 Jun 2023 04:14:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231609AbjFWIOZ (ORCPT ); Fri, 23 Jun 2023 04:14:25 -0400 Received: from 167-179-156-38.a7b39c.syd.nbn.aussiebb.net (167-179-156-38.a7b39c.syd.nbn.aussiebb.net [167.179.156.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 305C82122; Fri, 23 Jun 2023 01:14:17 -0700 (PDT) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1qCbvf-006KMj-RW; Fri, 23 Jun 2023 16:14:04 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Fri, 23 Jun 2023 16:14:03 +0800 Date: Fri, 23 Jun 2023 16:14:03 +0800 From: Herbert Xu To: Mario Limonciello Cc: Tom Lendacky , John Allen , "David S . Miller" , linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org Subject: Re: [PATCH v4 05/11] crypto: ccp: Add support for fetching a nonce for dynamic boost control Message-ID: References: <20230608111757.32054-1-mario.limonciello@amd.com> <20230608111757.32054-6-mario.limonciello@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230608111757.32054-6-mario.limonciello@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 08, 2023 at 06:17:51AM -0500, Mario Limonciello wrote: > > +const struct file_operations dbc_fops = { > + .owner = THIS_MODULE, > + .unlocked_ioctl = dbc_ioctl, > +}; This needs to be static. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt