From: Xu Yilun <yilun.xu@intel.com>
To: Marco Pagani <marpagan@redhat.com>
Cc: Moritz Fischer <mdf@kernel.org>, Wu Hao <hao.wu@intel.com>,
Tom Rix <trix@redhat.com>,
linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org
Subject: Re: [PATCH v7 2/4] fpga: add an initial KUnit suite for the FPGA Bridge
Date: Sun, 25 Jun 2023 15:33:29 +0800 [thread overview]
Message-ID: <ZJftyXGY5TbEqPqk@yilunxu-OptiPlex-7050> (raw)
In-Reply-To: <20230616154405.220502-3-marpagan@redhat.com>
On 2023-06-16 at 17:44:03 +0200, Marco Pagani wrote:
> The suite tests the basic behaviors of the FPGA Bridge including
> the functions that operate on a list of Bridges.
^
why uppercase?
>
> Signed-off-by: Marco Pagani <marpagan@redhat.com>
> ---
> drivers/fpga/tests/fpga-bridge-test.c | 175 ++++++++++++++++++++++++++
> 1 file changed, 175 insertions(+)
> create mode 100644 drivers/fpga/tests/fpga-bridge-test.c
>
> diff --git a/drivers/fpga/tests/fpga-bridge-test.c b/drivers/fpga/tests/fpga-bridge-test.c
> new file mode 100644
> index 000000000000..fce67ac59a7c
> --- /dev/null
> +++ b/drivers/fpga/tests/fpga-bridge-test.c
> @@ -0,0 +1,175 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * KUnit test for the FPGA Bridge
> + *
> + * Copyright (C) 2023 Red Hat, Inc.
> + *
> + * Author: Marco Pagani <marpagan@redhat.com>
> + */
> +
> +#include <linux/types.h>
> +#include <linux/module.h>
> +#include <linux/device.h>
> +#include <kunit/test.h>
> +#include <linux/fpga/fpga-bridge.h>
alphabetical order please.
Others LGTM.
Acked-by: Xu Yilun <yilun.xu@intel.com>
next prev parent reply other threads:[~2023-06-25 7:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 15:44 [PATCH v7 0/4] fpga: add initial KUnit tests for the subsystem Marco Pagani
2023-06-16 15:44 ` [PATCH v7 1/4] fpga: add an initial KUnit suite for the FPGA Manager Marco Pagani
2023-06-25 7:11 ` Xu Yilun
2023-06-27 13:23 ` Marco Pagani
2023-06-16 15:44 ` [PATCH v7 2/4] fpga: add an initial KUnit suite for the FPGA Bridge Marco Pagani
2023-06-25 7:33 ` Xu Yilun [this message]
2023-06-27 13:26 ` Marco Pagani
2023-06-16 15:44 ` [PATCH v7 3/4] fpga: add an initial KUnit suite for the FPGA Region Marco Pagani
2023-06-25 7:52 ` Xu Yilun
2023-06-16 15:44 ` [PATCH v7 4/4] fpga: add configuration for the FPGA KUnit test suites Marco Pagani
2023-06-25 8:23 ` Xu Yilun
2023-06-27 16:19 ` Marco Pagani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJftyXGY5TbEqPqk@yilunxu-OptiPlex-7050 \
--to=yilun.xu@intel.com \
--cc=hao.wu@intel.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marpagan@redhat.com \
--cc=mdf@kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®