From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13F85EB64DC for ; Sun, 25 Jun 2023 14:54:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230242AbjFYOyG (ORCPT ); Sun, 25 Jun 2023 10:54:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229452AbjFYOyE (ORCPT ); Sun, 25 Jun 2023 10:54:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3B9D1A4; Sun, 25 Jun 2023 07:54:02 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 614BA60B42; Sun, 25 Jun 2023 14:54:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AFEC3C433C0; Sun, 25 Jun 2023 14:54:00 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="WmH9DycT" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1687704835; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DXHrakrWANJGXtSmv2LXWfIVLyVyzM/MWJ9MJLB4jFA=; b=WmH9DycTnbOnz5PFXFGNihIAxsJ9ufubvgMJ5GKS/0JS2uth5avKSoDYBqFhHvhMY0nEYe va4Nw6EYatoyErsBgqxEMqR/54Vq9NiL+hSDoH3Balg/Ww8uprdkI0OisyAThbtb7kbXQS HyxNOwlGIlGCo7NagSFvHGUDKjcKSFY= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 28262728 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sun, 25 Jun 2023 14:53:55 +0000 (UTC) Date: Sun, 25 Jun 2023 16:53:53 +0200 From: "Jason A. Donenfeld" To: Paul Menzel Cc: Mario Limonciello , linux-integrity@vger.kernel.org, Jarkko Sakkinen , James Bottomley , LKML , Jason Gunthorpe , Peter Huewe Subject: Re: MSI B350M MORTAR: tpm tpm0: AMD fTPM version 0x3005700000004 causes system stutter; hwrng disabled Message-ID: References: <8999a30b-e165-f39d-864a-ce1c559e725d@molgen.mpg.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8999a30b-e165-f39d-864a-ce1c559e725d@molgen.mpg.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 25, 2023 at 10:20:22AM +0200, Paul Menzel wrote: > Thank you for your great work on the Linux kernel. > > On an MSI MS-7A37/B350M MORTAR (MS-7A37) even updating to their latest > system firmware 1.O7 released on their Web site on May, 23rd 2023 [1]. > > > Beschreibung: > > - AGESA ComboAm4v2PI 1.2.0.A. update. > > - TPM Out of Bounds Access security patch. > > But Linux 6.4.-rc7 still disables the hwrng from AMD fTPM. > > Jun 24 21:32:09.978772 tokeiihto kernel: DMI: Micro-Star > International Co., Ltd. MS-7A37/B350M MORTAR (MS-7A37), BIOS 1.O7 05/09/2023 > […] > Jun 24 21:32:10.259986 tokeiihto kernel: tpm tpm0: AMD fTPM > version 0x3005700000004 causes system stutter; hwrng disabled > > Unfortunately, the warning does not say, what firmware version is > needed, and what the user can do about it. > > The comment in the code, added in v6.3-rc2 with commit f1324bbc4011 > (tpm: disable hwrng for fTPM on some AMD designs) [2], says: > > /* > * Some AMD fTPM versions may cause stutter > * https://www.amd.com/en/support/kb/faq/pa-410 > * > * Fixes are available in two series of fTPM firmware: > * 6.x.y.z series: 6.0.18.6 + > * 3.x.y.z series: 3.57.y.5 + > */ > > Mapping 0x3005700000004 from the Linux warning to the comment, I assume > the board’s firmware is 3.57.0.4? > > What AGESA ComboAm4v2PI would MSI need to ship, so the issue is fixed? > The previous system firmware version shipped 3.4e.0.4? (Is it decimal or > hexadecimal?) Sounds like this is a question for MSI - why they haven't updated from 3.57.y.4 to 3.57.y.5+. What can we possibly say about this from a Linux perspective? The Linux code apparently is working as designed by avoiding using the buggy firmware gracefully.