From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 914D8EB64D9
	for <linux-kernel@archiver.kernel.org>; Tue, 27 Jun 2023 04:05:30 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229926AbjF0EF0 (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Tue, 27 Jun 2023 00:05:26 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53326 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229527AbjF0EFV (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 27 Jun 2023 00:05:21 -0400
Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C851DE59;
        Mon, 26 Jun 2023 21:05:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version
        :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=RsyF4h6uoThSvw3Iku4RrSPBs0D/JAtSb0sn0qxxh20=; b=Zb4bAeY+ZUGIlTx6WZmKQEwcds
        pkXLg56Ft7TV3uU3ZBjuckl/fvKej5gLQkonpvu37uVL3mtmYulH9uNbOBPHu8YPDi5U+g2S+osAN
        7Lb8NdhZwhFZc1gA9uEBqWbraiK9LVwW+C0lDbkigoi9ZMcH1ow/wmaXGBhm3JgC3LRszv00fK+82
        b4pwUH5W74zAX9Snl/D/7HWNtjPJW9sN9kkWwsumzjyd5iVYRi4GmH1IEJ/iXreNjgB06usomOOiS
        VSc9rDRIdBmEW6DN0ouQWqIJ2Y+dR22mdHVixj5DqY5/cmZwtVTtWy/pgrIkNihtrF7XMC8K2MBPo
        kk/ojpKg==;
Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux))
        id 1qDzx8-00BeBk-2A;
        Tue, 27 Jun 2023 04:05:18 +0000
Date:   Mon, 26 Jun 2023 21:05:18 -0700
From:   Christoph Hellwig <hch@infradead.org>
To:     "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc:     linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, Jan Kara <jack@suse.com>,
        David Howells <dhowells@redhat.com>
Subject: Re: [PATCH 01/12] writeback: Factor out writeback_finish()
Message-ID: <ZJpf/gh8rUN82ARF@infradead.org>
References: <20230626173521.459345-1-willy@infradead.org>
 <20230626173521.459345-2-willy@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230626173521.459345-2-willy@infradead.org>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jun 26, 2023 at 06:35:10PM +0100, Matthew Wilcox (Oracle) wrote:
> +	struct folio_batch fbatch;
> +	pgoff_t done_index;
> +	int err;
> +

I think this really needs a comment that it should only be used for
the writeback iterator.  In fact this whole structure could use a lot
more comments on what should / can be set by the caller, and what is
internal.

> +	unsigned range_whole:1;		/* entire file */

Same here.