From: Sean Christopherson <seanjc@google.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: cocci@inria.fr, kernel-janitors@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Julia Lawall <Julia.Lawall@inria.fr>,
Nicolas Palix <nicolas.palix@imag.fr>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [cocci] [PATCH] Revert "debugfs, coccinelle: check for obsolete DEFINE_SIMPLE_ATTRIBUTE() usage"
Date: Tue, 11 Jul 2023 07:12:48 -0700 [thread overview]
Message-ID: <ZK1jYI/wyaxWnXrz@google.com> (raw)
In-Reply-To: <a1679697-827b-0e3a-0948-c84510fcbecc@web.de>
On Tue, Jul 11, 2023, Markus Elfring wrote:
> > Remove coccinelle's recommendation to use DEFINE_SIMPLE_ATTRIBUTE()
> > instead of DEFINE_SIMPLE_ATTRIBUTE().
>
> I find this wording inappropriate for a change request
> because of an undesirable term duplication.
> Would you like to refer to the identifier “DEFINE_DEBUGFS_ATTRIBUTE” here?
Doh, copy+paste fail on my part.
> > Regardless of whether or not the
> > "significant overhead" incurred by debugfs_create_file() is actually
> > meaningful, warnings from the script have led to a rash of low-quality
> > patches that have sowed confusion and consumed maintainer time for little
> > to no benefit. There have been no less than four attempts to "fix" KVM,
> > and a quick search on lore shows that KVM is not alone.
>
> Will such information trigger any further clarification?
I don't quite follow the question. What information, and what clarification?
prev parent reply other threads:[~2023-07-11 14:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 17:06 Sean Christopherson
2023-07-10 17:12 ` Greg Kroah-Hartman
[not found] ` <a1679697-827b-0e3a-0948-c84510fcbecc@web.de>
2023-07-11 14:12 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZK1jYI/wyaxWnXrz@google.com \
--to=seanjc@google.com \
--cc=Julia.Lawall@inria.fr \
--cc=Markus.Elfring@web.de \
--cc=cocci@inria.fr \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.palix@imag.fr \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®