From: Xu Yilun <yilun.xu@intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, frank.li@vivo.com
Cc: Yangtao Li <frank.li@vivo.com>, Moritz Fischer <mdf@kernel.org>,
Wu Hao <hao.wu@intel.com>, Tom Rix <trix@redhat.com>,
Alan Tull <atull@opensource.altera.com>,
Moritz Fischer <moritz.fischer@ettus.com>,
linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] fpga: socfpga-a10: Fix incorrect return value of devm_regmap_init_mmio
Date: Wed, 12 Jul 2023 09:42:41 +0800 [thread overview]
Message-ID: <ZK4FEdv6j+83+7nV@yilunxu-OptiPlex-7050> (raw)
In-Reply-To: <2023071010-anatomy-paying-3e3e@gregkh>
On 2023-07-10 at 16:11:35 +0200, Greg Kroah-Hartman wrote:
> On Mon, Jul 10, 2023 at 09:38:30PM +0800, Yangtao Li wrote:
> > When devm_regmap_init_mmio fails, we should return PTR_ERR(priv->regmap)
> > instead of -ENODEV.
> >
> > Fixes: acbb910ae04b ("fpga-manager: Add Socfpga Arria10 support")
>
> Why are you not also including a cc: stable@ tag here?
The change is to propagate the error number produced by regmap, instead
of using a fixed error number.
I think this is more of an improvement, not a bug fix. So no need to
merge to stable? And the changelog should be improved to avoid
confusing.
Thanks,
Yilun
>
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2023-07-12 1:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 13:38 [PATCH v2 1/3] fpga: fpga-mgr: altera-pr-ip: Convert to devm_platform_ioremap_resource() Yangtao Li
2023-07-10 13:38 ` [PATCH v2 2/3] fpga: socfpga-a10: " Yangtao Li
2023-07-15 14:51 ` Xu Yilun
2023-07-10 13:38 ` [PATCH v2 3/3] fpga: socfpga-a10: Fix incorrect return value of devm_regmap_init_mmio Yangtao Li
2023-07-10 14:11 ` Greg Kroah-Hartman
2023-07-12 1:42 ` Xu Yilun [this message]
2023-07-15 14:50 ` [PATCH v2 1/3] fpga: fpga-mgr: altera-pr-ip: Convert to devm_platform_ioremap_resource() Xu Yilun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZK4FEdv6j+83+7nV@yilunxu-OptiPlex-7050 \
--to=yilun.xu@intel.com \
--cc=atull@opensource.altera.com \
--cc=frank.li@vivo.com \
--cc=gregkh@linuxfoundation.org \
--cc=hao.wu@intel.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=moritz.fischer@ettus.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®