From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Bin Liu <b-liu@ti.com>
Subject: Re: [PATCH v1 1/1] usb: musb: Use read_poll_timeout()
Date: Mon, 10 Jul 2023 12:44:35 +0300 [thread overview]
Message-ID: <ZKvTA5fQxPqIdX1n@smile.fi.intel.com> (raw)
In-Reply-To: <CACRpkdbySh+XFUDnFWUQHULYag0hukJ_ogfSREPLvs1iV=YmwQ@mail.gmail.com>
On Tue, Jul 04, 2023 at 11:08:41AM +0200, Linus Walleij wrote:
> On Mon, Jul 3, 2023 at 2:19 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
>
> > Use read_poll_timeout() instead of open coding it.
> > In the same time, fix the typo in the error message.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> (...)
> > + ret = read_poll_timeout(gpiod_get_value, reg, !reg, 1000, 100000, true,
> > + glue->intpin);
>
> Wow that's really cool. I had no idea that you could use read_poll_timeout()
> together with gpiod_get_value() like this!
Yep, after 5f5323a14cad ("iopoll: introduce read_poll_timeout macro").
I just realized that we need to bump the sleep_us parameter as beneath
it divides it by 4, so I would put 5000 there in v2.
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Thank you!
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-07-10 9:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 12:19 Andy Shevchenko
2023-07-04 9:08 ` Linus Walleij
2023-07-10 9:44 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKvTA5fQxPqIdX1n@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=b-liu@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®