From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCDF5EB64D9 for ; Mon, 10 Jul 2023 12:01:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231205AbjGJMBQ (ORCPT ); Mon, 10 Jul 2023 08:01:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230501AbjGJMBO (ORCPT ); Mon, 10 Jul 2023 08:01:14 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5BCA8F9 for ; Mon, 10 Jul 2023 05:01:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B9A0060FD8 for ; Mon, 10 Jul 2023 12:01:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18618C433C8; Mon, 10 Jul 2023 12:01:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688990471; bh=hi2KjYVNB1fgMeU4P1IicTBxc+ULEU0k8ide4WBCPI0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eUf+bOsBAEEtyVa+Tu1NcCxNEphDSnC05lrP4V2VIQBaufImErwI42F5EzPJ0MezX SKXml0eAJvfoOhNufaG/FFftOj5O85WkSU+EoDWLvENzmFx3yMOfr58/Cf1Z0cKQvc 43NWvDGjxTh58W/y+ucwfNf12IomMSRZh9iZUPtDAl5l8bAoI9bLjUJsyy6Qp9O1kt VpP37cZyPeIkUkFQe9ycH3/S/plF5OkiXOA8SZ92QcKQshxDOzXiWgPQIWhgciIf05 JfSeULY9SLcRUHCMIBMkqQxmfAjcqdKcFA/++E4awkkOmZtLjY1Rea/dBIhZx/KQSh baWFwlbKT/rGg== Received: from johan by xi.lan with local (Exim 4.96) (envelope-from ) id 1qIpaD-0003Lu-15; Mon, 10 Jul 2023 14:01:37 +0200 Date: Mon, 10 Jul 2023 14:01:37 +0200 From: Johan Hovold To: Amadeusz =?utf-8?B?U8WCYXdpxYRza2k=?= Cc: Johan Hovold , Mark Brown , Vinod Koul , Bard Liao , Pierre-Louis Bossart , Sanyog Kale , Srinivas Kandagatla , Banajit Goswami , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Alex Elder Subject: Re: [PATCH 7/8] ASoC: topology: suppress probe deferral errors Message-ID: References: <20230705123018.30903-1-johan+linaro@kernel.org> <20230705123018.30903-8-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 06, 2023 at 09:25:26AM +0200, Amadeusz Sławiński wrote: > On 7/6/2023 8:14 AM, Johan Hovold wrote: > > In short, it is not correct to use dev_err_probe() here as this is not a > > probe function. > > > > dev_err_probe() is tied to driver core and will specifically allocate > > and associate an error message with the struct device on probe > > deferrals, which is later freed when the struct device is bound to a > > driver (or released). > I guess you mean call to: device_set_deferred_probe_reason(dev, &vaf); > perhaps functionality could be extended to allow to skip this call and > just do prints? Or just add separate dev_err_defer function without this > step, although it would be best if they could share parts of code. Feel free to suggest adding such a function if you think it's worthwhile. It doesn't exist today it should not be a prerequisite for suppressing these error messages. Johan