From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27234C001E0 for ; Tue, 25 Jul 2023 13:13:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229764AbjGYNNS (ORCPT ); Tue, 25 Jul 2023 09:13:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229447AbjGYNNQ (ORCPT ); Tue, 25 Jul 2023 09:13:16 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9D9BE3; Tue, 25 Jul 2023 06:13:15 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6600,9927,10781"; a="367743563" X-IronPort-AV: E=Sophos;i="6.01,230,1684825200"; d="scan'208";a="367743563" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jul 2023 06:13:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10781"; a="1056787134" X-IronPort-AV: E=Sophos;i="6.01,230,1684825200"; d="scan'208";a="1056787134" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga005.fm.intel.com with ESMTP; 25 Jul 2023 06:13:13 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qOHqi-00AvPe-0V; Tue, 25 Jul 2023 16:13:12 +0300 Date: Tue, 25 Jul 2023 16:13:11 +0300 From: Andy Shevchenko To: Andrei Coardos Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, brgl@bgdev.pl, linus.walleij@linaro.org, Alexandru Ardelean Subject: Re: [PATCH v2] gpio: mlxbf2: remove unneeded platform_set_drvdata() call Message-ID: References: <20230725123045.6367-1-aboutphysycs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230725123045.6367-1-aboutphysycs@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 25, 2023 at 03:30:45PM +0300, Andrei Coardos wrote: > This function call was found to be unnecessary as there is no equivalent > platform_get_drvdata() call to access the private data of the driver. This is simply not true. NAK. > Also, the private data is defined in this driver, so there is no risk of > it being accessed outside of this driver file. -- With Best Regards, Andy Shevchenko