From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CEB8C04E69 for ; Tue, 25 Jul 2023 13:25:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230264AbjGYNZ6 (ORCPT ); Tue, 25 Jul 2023 09:25:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229788AbjGYNZy (ORCPT ); Tue, 25 Jul 2023 09:25:54 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1559419AF; Tue, 25 Jul 2023 06:25:44 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6600,9927,10782"; a="398633744" X-IronPort-AV: E=Sophos;i="6.01,230,1684825200"; d="scan'208";a="398633744" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jul 2023 06:25:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10782"; a="839864648" X-IronPort-AV: E=Sophos;i="6.01,230,1684825200"; d="scan'208";a="839864648" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP; 25 Jul 2023 06:25:41 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qOI2l-00BM3E-1h; Tue, 25 Jul 2023 16:25:39 +0300 Date: Tue, 25 Jul 2023 16:25:39 +0300 From: Andy Shevchenko To: Andrei Coardos Cc: linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, angelogioacchino.delregno@collabora.com, matthias.bgg@gmail.com, brgl@bgdev.pl, linus.walleij@linaro.org, Alexandru Ardelean Subject: Re: [PATCH] gpio: mt7621: remove unnecessary call to platfrom_set_drvdata() Message-ID: References: <20230721130838.26616-1-aboutphysycs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 21, 2023 at 06:10:32PM +0300, Andy Shevchenko wrote: > On Fri, Jul 21, 2023 at 04:08:38PM +0300, Andrei Coardos wrote: > > This function call was found to be unnecessary as there is no equivalent > > platform_get_drvdata() call to access the private data of the driver. Not true. > > Also, the private data is defined in this driver, so there is no risk of > > it being accessed outside of this driver file. > > Reviewed-by: Andy Shevchenko I have to withdraw this, the patch is wrong. NAK. Sorry for the confusion (I have looked for the wrong pattern). -- With Best Regards, Andy Shevchenko