From: Simon Horman <simon.horman@corigine.com>
To: "Radu Pirea (NXP OSS)" <radu-nicolae.pirea@oss.nxp.com>
Cc: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, richardcochran@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
sebastian.tobuschat@nxp.com
Subject: Re: [PATCH net-next v4 03/11] net: phy: nxp-c45-tja11xx: prepare the ground for TJA1120
Date: Tue, 25 Jul 2023 18:07:18 +0200 [thread overview]
Message-ID: <ZL/zNmrewrVtp+0g@corigine.com> (raw)
In-Reply-To: <20230724141232.233101-4-radu-nicolae.pirea@oss.nxp.com>
On Mon, Jul 24, 2023 at 05:12:24PM +0300, Radu Pirea (NXP OSS) wrote:
...
> static void nxp_c45_get_strings(struct phy_device *phydev, u8 *data)
> {
> + const struct nxp_c45_phy_data *phy_data = nxp_c45_get_data(phydev);
> + size_t count = nxp_c45_get_sset_count(phydev);
> + size_t idx;
> size_t i;
>
> - for (i = 0; i < ARRAY_SIZE(nxp_c45_hw_stats); i++) {
> + for (i = 0; i < count; i++) {
> + if (i < ARRAY_SIZE(common_hw_stats)) {
> + strncpy(data + i * ETH_GSTRING_LEN,
> + common_hw_stats[i].name, ETH_GSTRING_LEN);
Hi Radu,
Checkpatch suggests using strscpy() here.
Link: https://github.com/KSPP/linux/issues/90:0
...
next prev parent reply other threads:[~2023-07-25 16:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 14:12 [PATCH net-next v4 00/11] Add TJA1120 support Radu Pirea (NXP OSS)
2023-07-24 14:12 ` [PATCH net-next v4 01/11] net: phy: nxp-c45-tja11xx: use phylib master/slave implementation Radu Pirea (NXP OSS)
2023-07-24 14:12 ` [PATCH net-next v4 02/11] net: phy: nxp-c45-tja11xx: remove RX BIST frame counters Radu Pirea (NXP OSS)
2023-07-25 20:10 ` Andrew Lunn
2023-07-24 14:12 ` [PATCH net-next v4 03/11] net: phy: nxp-c45-tja11xx: prepare the ground for TJA1120 Radu Pirea (NXP OSS)
2023-07-25 16:07 ` Simon Horman [this message]
2023-07-24 14:12 ` [PATCH net-next v4 04/11] net: phy: nxp-c45-tja11xx: use get_features Radu Pirea (NXP OSS)
2023-07-24 14:12 ` [PATCH net-next v4 05/11] net: phy: nxp-c45-tja11xx: add TJA1120 support Radu Pirea (NXP OSS)
2023-07-24 14:12 ` [PATCH net-next v4 06/11] net: phy: nxp-c45-tja11xx: enable LTC sampling on both ext_ts edges Radu Pirea (NXP OSS)
2023-07-24 14:12 ` [PATCH net-next v4 07/11] net: phy: nxp-c45-tja11xx: read egress ts on TJA1120 Radu Pirea (NXP OSS)
2023-07-24 14:12 ` [PATCH net-next v4 08/11] net: phy: nxp-c45-tja11xx: handle FUSA irq Radu Pirea (NXP OSS)
2023-07-24 14:12 ` [PATCH net-next v4 09/11] net: phy: nxp-c45-tja11xx: run cable test with the PHY in test mode Radu Pirea (NXP OSS)
2023-07-24 14:12 ` [PATCH net-next v4 10/11] net: phy: nxp-c45-tja11xx: read ext trig ts on TJA1120 Radu Pirea (NXP OSS)
2023-07-24 14:12 ` [PATCH net-next v4 11/11] net: phy: nxp-c45-tja11xx: reset PCS if the link goes down Radu Pirea (NXP OSS)
2023-07-25 16:07 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZL/zNmrewrVtp+0g@corigine.com \
--to=simon.horman@corigine.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=radu-nicolae.pirea@oss.nxp.com \
--cc=richardcochran@gmail.com \
--cc=sebastian.tobuschat@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®