From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: Jan-Benedict Glaw <jbglaw@lug-owl.de>,
Guillaume Tucker <guillaume.tucker@collabora.com>,
Huacai Chen <chenhuacai@loongson.cn>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] MIPS: Fix build issues from the introduction of `need-compiler'
Date: Tue, 25 Jul 2023 10:44:46 +0200 [thread overview]
Message-ID: <ZL+LfqvL/tBGnUF3@alpha.franken.de> (raw)
In-Reply-To: <alpine.DEB.2.21.2307180025120.62448@angie.orcam.me.uk>
On Tue, Jul 18, 2023 at 03:37:13PM +0100, Maciej W. Rozycki wrote:
> Hi,
>
> With the addition of the `need-compiler' variable the `Makefile.compiler'
> fragment is not included with no-build targets such as `modules_install',
> which in turn means $(call cc-option,), etc. are no-ops with these targets
> and any attempt to evaluate these function calls causes all kinds of weird
> behaviour to happen.
>
> The solution is to avoid making these calls in the first place, as they
> are surely irrelevant where the compiler is not going to be otherwise
> invoked. This small patch series fixes two places known-affected in the
> MIPS Makefile fragment and also included a follow-up revert of an earlier
> misguided attempt. See individual change descriptions for details.
>
> Verified with `decstation_64_defconfig' and `fuloong2e_defconfig' using
> `modules_install'. Please apply.
series applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2023-07-25 9:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 14:37 Maciej W. Rozycki
2023-07-18 14:37 ` [PATCH 1/3] MIPS: Fix CONFIG_CPU_DADDI_WORKAROUNDS `modules_install' regression Maciej W. Rozycki
2023-07-19 11:34 ` Philippe Mathieu-Daudé
2023-07-18 14:37 ` [PATCH 2/3] MIPS: Only fiddle with CHECKFLAGS if `need-compiler' Maciej W. Rozycki
2023-07-18 14:45 ` Guillaume Tucker
2023-07-18 14:37 ` [PATCH 3/3] Revert MIPS: Loongson: Fix build error when make modules_install Maciej W. Rozycki
2023-07-18 14:54 ` [PATCH 0/3] MIPS: Fix build issues from the introduction of `need-compiler' Huacai Chen
2023-07-19 15:39 ` Maciej W. Rozycki
2023-07-20 1:55 ` Huacai Chen
2023-07-21 10:53 ` Maciej W. Rozycki
2023-07-25 8:44 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZL+LfqvL/tBGnUF3@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=chenhuacai@loongson.cn \
--cc=guillaume.tucker@collabora.com \
--cc=jbglaw@lug-owl.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=macro@orcam.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®