From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70949C001DE for ; Tue, 25 Jul 2023 09:00:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232277AbjGYJAF (ORCPT ); Tue, 25 Jul 2023 05:00:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232345AbjGYI76 (ORCPT ); Tue, 25 Jul 2023 04:59:58 -0400 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 29B0EBD; Tue, 25 Jul 2023 01:59:53 -0700 (PDT) Received: from uucp by elvis.franken.de with local-rmail (Exim 3.36 #1) id 1qODtS-0008Gv-00; Tue, 25 Jul 2023 10:59:46 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 1D79DC01F0; Tue, 25 Jul 2023 10:48:40 +0200 (CEST) Date: Tue, 25 Jul 2023 10:48:40 +0200 From: Thomas Bogendoerfer To: Rob Herring Cc: Florian Fainelli , Broadcom internal kernel review list , John Crispin , devicetree@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] MIPS: Explicitly include correct DT includes Message-ID: References: <20230714174028.4040093-1-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230714174028.4040093-1-robh@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 14, 2023 at 11:40:27AM -0600, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include platform_device.h > and of.h. As a result, there's a pretty much random mix of those include > files used throughout the tree. In order to detangle these headers and > replace the implicit includes with struct declarations, users need to > explicitly include the correct includes. > > Signed-off-by: Rob Herring > --- > arch/mips/bmips/setup.c | 1 - > arch/mips/cavium-octeon/flash_setup.c | 3 ++- > arch/mips/lantiq/irq.c | 2 +- > arch/mips/lantiq/xway/dcdc.c | 3 ++- > arch/mips/lantiq/xway/gptu.c | 4 ++-- > arch/mips/lantiq/xway/sysctrl.c | 1 - > arch/mips/lantiq/xway/vmmc.c | 3 ++- > arch/mips/pci/pci-lantiq.c | 4 ++-- > arch/mips/pci/pci-rt2880.c | 5 ++--- > arch/mips/pic32/pic32mzda/config.c | 1 - > arch/mips/ralink/irq.c | 2 +- > arch/mips/ralink/of.c | 2 +- > arch/mips/ralink/prom.c | 2 -- > 13 files changed, 15 insertions(+), 18 deletions(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]