From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5366C001B0 for ; Sun, 23 Jul 2023 20:37:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229771AbjGWUhp (ORCPT ); Sun, 23 Jul 2023 16:37:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229468AbjGWUhm (ORCPT ); Sun, 23 Jul 2023 16:37:42 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 232E0E49; Sun, 23 Jul 2023 13:37:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=qy3ZfgxHtTZ+H6cA0c7w6ZZsFamgKKUHdZT7/5uteAk=; b=kTr4Znvd56MMHUXN0EHN8A34Ch yiVFzsJ9la7YOzyYLmo8iAxAVQiM+usii43xNwFPgEB3Dm89Ext45zyoZLgfbRA4T8YE2AeEfACaF hdlN4RXUJW4jvNU4NOJzGo99BTK+HQo9ASaYlCCYkYPE+iNCCcK8LV1kVkn/JsqOaCl/XMoyn0hJx RQw2aR4JbD5kt7Z+XuffKRiNWeewjEJlhH9GuiZ0SgDFWquMWUKmsqdV/kHmkhcqVJkPVS4IHakPG tjL6ymvrdGUk+ht5MZQDwVUrFlesfweWrITUN076QSLeriL/Y/lb2HtYOOEDJfCYwzH0LEY4YDomT 0eS8ohCg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qNfpX-003aTh-8Y; Sun, 23 Jul 2023 20:37:27 +0000 Date: Sun, 23 Jul 2023 21:37:27 +0100 From: Matthew Wilcox To: Miaohe Lin Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [PATCH] mm/memcg: fix obsolete function name in mem_cgroup_protection() Message-ID: References: <20230723032538.3190239-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230723032538.3190239-1-linmiaohe@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 23, 2023 at 11:25:38AM +0800, Miaohe Lin wrote: > @@ -582,9 +582,9 @@ static inline void mem_cgroup_protection(struct mem_cgroup *root, > /* > * There is no reclaim protection applied to a targeted reclaim. > * We are special casing this specific case here because > - * mem_cgroup_protected calculation is not robust enough to keep > - * the protection invariant for calculated effective values for > - * parallel reclaimers with different reclaim target. This is > + * mem_cgroup_calculate_protection calculation is not robust enough > + * to keep the protection invariant for calculated effective values > + * for parallel reclaimers with different reclaim target. This is > * especially a problem for tail memcgs (as they have pages on LRU) > * which would want to have effective values 0 for targeted reclaim > * but a different value for external reclaim. This reads a little awkwardly now. How about: * We are special casing this specific case here because - * mem_cgroup_protected calculation is not robust enough to keep + * mem_cgroup_calculate_protection is not robust enough to keep * the protection invariant for calculated effective values for * parallel reclaimers with different reclaim target. This is