From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A621C001B0 for ; Sun, 23 Jul 2023 22:45:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229883AbjGWWph (ORCPT ); Sun, 23 Jul 2023 18:45:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229493AbjGWWpf (ORCPT ); Sun, 23 Jul 2023 18:45:35 -0400 Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11B751AA for ; Sun, 23 Jul 2023 15:45:35 -0700 (PDT) Received: by mail-ot1-f42.google.com with SMTP id 46e09a7af769-6b9ed0831bcso2884343a34.0 for ; Sun, 23 Jul 2023 15:45:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690152334; x=1690757134; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=H+ooKXUaxz7S7zGhiMiEBGa8/B1a4kT9H2dXrsEtE5M=; b=Ug+sTPW/Hr8EOF8df+/z6LxEMtabphua/4aUyUyFjN1MVaj2O0yO9HumkzKkEHmZfj KcHa+MGq8mcddfLvM8mIbynwl11Qh2Kwu+QX2lFxSbeBXPcTVMgpSO/hEQ4OjvMRNTAi DxBYzpdYU3/FnqC7wK3qdxU0MRi5HHse6FZdHM8Q5LYyrzinaJkgHV7Kf9JZVRxZi0my JL+zjXWnlpFyr9V04wAJPeusV4SWbNgA0Mx0e4CZztwlHjfgBWzIPfWVKPxn0IStC8Fu kADF4wdx+4kSd25mq5H6AevBU1j9XHBRelpbCCS1GsI2ReJqKdTDIXqhmqGDWMi4ZOjQ Ufug== X-Gm-Message-State: ABy/qLYQD9eAG8GKYVQVInmSGL9pxG/1hsTPO/1C1MBI2GLiHyvKUfId MgOFtxmTX9BUZJLBQssBso4= X-Google-Smtp-Source: APBJJlHXJi/sSucbixQZ2fbJ2iqQ2gCiVMnMjHLqHySR77gqtmD2eVRUo/sITXTo+JrO1T6HsB/LEw== X-Received: by 2002:a9d:685a:0:b0:6b8:7a79:db37 with SMTP id c26-20020a9d685a000000b006b87a79db37mr6887438oto.22.1690152334350; Sun, 23 Jul 2023 15:45:34 -0700 (PDT) Received: from liuwe-devbox-debian-v2 ([20.69.120.36]) by smtp.gmail.com with ESMTPSA id q6-20020a170902bd8600b001b9cf522c07sm7342873pls.57.2023.07.23.15.45.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jul 2023 15:45:33 -0700 (PDT) Date: Sun, 23 Jul 2023 22:45:32 +0000 From: Wei Liu To: Thomas Gleixner Cc: LKML , x86@kernel.org, Linus Torvalds , Andrew Cooper , Tom Lendacky , Paolo Bonzini , Wei Liu , Arjan van de Ven , Juergen Gross Subject: Re: [patch 47/58] x86/apic: Remove pointless arguments from [native_]eoi_write() Message-ID: References: <20230717223049.327865981@linutronix.de> <20230717223225.875917164@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230717223225.875917164@linutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 18, 2023 at 01:15:47AM +0200, Thomas Gleixner wrote: > Every callsite hands in the same constants which is a pointless exercise > and cannot be optimized by the compiler due to the indirect calls. > > Use the constants in the eoi() callbacks and remove the arguments. > > Signed-off-by: Thomas Gleixner > --- > arch/x86/hyperv/hv_apic.c | 6 +++--- The change looks trivially correct. In conjunction with the function name change: Reviewed-by: Wei Liu