From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE67AC001DE for ; Mon, 24 Jul 2023 08:52:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231926AbjGXIww (ORCPT ); Mon, 24 Jul 2023 04:52:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231917AbjGXIwq (ORCPT ); Mon, 24 Jul 2023 04:52:46 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C24FFFB; Mon, 24 Jul 2023 01:52:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690188764; x=1721724764; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=AFK87Oy7ijOEjIfPgqTKmw5kmr9MTaaez0cnQ9KaiPk=; b=E9ltUVdfCeVw77AuoXWmkZPDA7VYUlSofBtZ/nnkLD/3RBKgmGsBKQXU IGlPOv7uSVmyf+7dbFkbnakI+WKRem6yyyULybPsoBenn+j1NkbyKwoVc 7naGuNj2jSzO1BiWAMFNCrKyorbyU4/KsD8Qme+FIwUgiCBBgh6MD+m2K ySK9zQE5Z7m6Hmqt+5nkUTgzXxoT9FSSXjGRbRwGIRtY5X5e5o/y0mnNm GCaEJu3YsDj7Yjrg8GjBXyEbVxgGsJwbrW5FAhH/7kWtJsUgaZXrgwmlN Cv7B+ukThpsUokg3dHm4j0aPKU4GC0SlSffJDv7FWl+dkZHIYdRyODlms w==; X-IronPort-AV: E=McAfee;i="6600,9927,10780"; a="398288419" X-IronPort-AV: E=Sophos;i="6.01,228,1684825200"; d="scan'208";a="398288419" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jul 2023 01:52:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10780"; a="728833974" X-IronPort-AV: E=Sophos;i="6.01,228,1684825200"; d="scan'208";a="728833974" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga007.fm.intel.com with ESMTP; 24 Jul 2023 01:52:41 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qNrJ1-005GiM-2f; Mon, 24 Jul 2023 11:52:39 +0300 Date: Mon, 24 Jul 2023 11:52:39 +0300 From: Andy Shevchenko To: Tony Lindgren Cc: Greg Kroah-Hartman , Jiri Slaby , Dhruva Gole , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , John Ogness , Johan Hovold , Sebastian Andrzej Siewior , Vignesh Raghavendra , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH v4 1/3] serial: core: Controller id cannot be negative Message-ID: References: <20230724050709.17544-1-tony@atomide.com> <20230724050709.17544-2-tony@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230724050709.17544-2-tony@atomide.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 24, 2023 at 08:07:03AM +0300, Tony Lindgren wrote: > The controller id cannot be negative. Let's fix the ctrl_id in preparation > for adding port_id to fix the device name. > > Fixes: 84a9582fd203 ("serial: core: Start managing serial controllers to enable runtime PM") > Reported-by: Andy Shevchenko > Andy Shevchenko ??? Missing Reviewed-by: I suppose? -- With Best Regards, Andy Shevchenko