mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Francesco Dolcini <francesco@dolcini.it>
To: Judith Mendez <jm@ti.com>
Cc: Francesco Dolcini <francesco@dolcini.it>,
	Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
	Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Francesco Dolcini <francesco.dolcini@toradex.com>
Subject: Re: [PATCH v1 1/2] arm64: dts: ti: k3-am62: Add MCU MCAN nodes
Date: Mon, 24 Jul 2023 18:22:44 +0200	[thread overview]
Message-ID: <ZL6lVGklNclkVu58@francesco-nb.int.toradex.com> (raw)
In-Reply-To: <42044653-cc22-131a-bf1b-e68ddfa0ff9d@ti.com>

Hello Judith,

On Mon, Jul 24, 2023 at 11:06:24AM -0500, Judith Mendez wrote:
> On 7/24/23 8:36 AM, Francesco Dolcini wrote:
> > From: Judith Mendez <jm@ti.com>
> > 
> > On AM62x there are no hardware interrupts routed to A53 GIC
> > interrupt controller for MCU MCAN IPs, so MCU MCAN nodes were
> > omitted from MCU dtsi.
> > 
> > Timer polling was introduced in commits [1][2] so now add MCU MCAN nodes
> > to the MCU dtsi for the Cortex A53.
> > 
> > [1] b382380c0d2d ("can: m_can: Add hrtimer to generate software interrupt")
> > [2] bb410c03b999 ("dt-bindings: net: can: Remove interrupt properties for MCAN")
> > 
> > Signed-off-by: Judith Mendez <jm@ti.com>
> > [fd: fixed labels to match datasheet numbering, revised commit message,
> >       fixed reg/reg-names order]
> > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> > ---

...

> Thanks for sending this patch, will also send for AM62ax.

Please have a look at the couple of changes I did:
 - corrected the label to be coherent with the datasheet and the other
   peripheral names
 - inverted "m_can" and "message_ram" regs/regs-names to fix a binding
   checker error.

These might be relevant also for the AM62a.

Francesco


  reply	other threads:[~2023-07-24 16:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-24 13:36 [PATCH v1 0/2] arm64: dts: ti: k3-am62: Add MCU MCAN Francesco Dolcini
2023-07-24 13:36 ` [PATCH v1 1/2] arm64: dts: ti: k3-am62: Add MCU MCAN nodes Francesco Dolcini
2023-07-24 16:06   ` Judith Mendez
2023-07-24 16:22     ` Francesco Dolcini [this message]
2023-07-24 16:25       ` Judith Mendez
2023-08-02  3:41   ` Nishanth Menon
2023-07-24 13:36 ` [PATCH v1 2/2] arm64: dts: ti: k3-am625-verdin: enable CAN_2 Francesco Dolcini
2023-08-02  3:43   ` Nishanth Menon
2023-08-02  7:42     ` Francesco Dolcini
2023-08-02 13:19       ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZL6lVGklNclkVu58@francesco-nb.int.toradex.com \
    --to=francesco@dolcini.it \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=francesco.dolcini@toradex.com \
    --cc=jm@ti.com \
    --cc=kristo@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®