From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0479AEB64DD for ; Mon, 24 Jul 2023 19:17:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230189AbjGXTRG (ORCPT ); Mon, 24 Jul 2023 15:17:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229926AbjGXTRD (ORCPT ); Mon, 24 Jul 2023 15:17:03 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6100910F5 for ; Mon, 24 Jul 2023 12:17:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fD8k9MJukbJAshMIcLKZEEu2SAeyY9acI66XfQU35Ek=; b=sxnyzx3VQpm/cp4YgIBl65ihk8 IiCLmsDvQjeY6Qi9IKGETOXrQAQvF9fJAXo03ZvxjCEM8gZ1b6pdfG9jgzSzTNxrs0wY+TIB6R9wm RAU3Au+rfyV7zPqDZsctTPQM74a+i5QBSV800egyEaDtTs4ZWeY9a1kJ6r+plac6eIaCWw/PyWu0D TrIpv7Gp8jflmyX/rYInQGQB2TzW8XVO/nBtQNlJSqQnGAQHoY4DrQAzhQvqI+hz8RmnsBTNhwXHI 3lx+HzxKyEOHjBmyOU42r61KoWLhZRTF6O29uf00biavZba+dfqJhgvQxLait+tOCTV+ppd6XHajt ByRbnn2g==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qO137-005I6r-0Y; Mon, 24 Jul 2023 19:16:53 +0000 Date: Mon, 24 Jul 2023 12:16:53 -0700 From: Luis Chamberlain To: Petr Mladek Cc: Rong Tao , prasad@linux.vnet.ibm.com, ast@kernel.org, frederic@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, mbenes@suse.cz, qperret@google.com, rongtao@cestc.cn, tglx@linutronix.de, will@kernel.org, mhiramat@kernel.org Subject: Re: [PATCH] samples/hw_breakpoint: Fix kernel BUG 'invalid opcode: 0000' Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 24, 2023 at 02:59:15PM +0200, Petr Mladek wrote: > On Mon 2023-07-24 18:47:58, Rong Tao wrote: > > From: Rong Tao > > > > Macro symbol_put() is defined as __symbol_put(__stringify(x)) > > > > ksym_name = "jiffies" > > symbol_put(ksym_name) > > > > will be resolved as > > > > __symbol_put("ksym_name") > > > > which is clearly wrong. So symbol_put must be replaced with __symbol_put. > > > > When we uninstall hw_breakpoint.ko (rmmod), a kernel bug occurs with the > > following error: > > > > [11381.854152] kernel BUG at kernel/module/main.c:779! > > [11381.854159] invalid opcode: 0000 [#2] PREEMPT SMP PTI > > [11381.854163] CPU: 8 PID: 59623 Comm: rmmod Tainted: G D OE 6.2.9-200.fc37.x86_64 #1 > > [11381.854167] Hardware name: To Be Filled By O.E.M. To Be Filled By O.E.M./B360M-HDV, BIOS P3.20 10/23/2018 > > [11381.854169] RIP: 0010:__symbol_put+0xa2/0xb0 > > [11381.854175] Code: 00 e8 92 d2 f7 ff 65 8b 05 c3 2f e6 78 85 c0 74 1b 48 8b 44 24 30 65 48 2b 04 25 28 00 00 00 75 12 48 83 c4 38 c3 cc cc cc cc <0f> 0b 0f 1f 44 00 00 eb de e8 c0 df d8 00 90 90 90 90 90 90 90 90 > > [11381.854178] RSP: 0018:ffffad8ec6ae7dd0 EFLAGS: 00010246 > > [11381.854181] RAX: 0000000000000000 RBX: ffffffffc1fd1240 RCX: 000000000000000c > > [11381.854184] RDX: 000000000000006b RSI: ffffffffc02bf7c7 RDI: ffffffffc1fd001c > > [11381.854186] RBP: 000055a38b76e7c8 R08: ffffffff871ccfe0 R09: 0000000000000000 > > [11381.854188] R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000 > > [11381.854190] R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000 > > [11381.854192] FS: 00007fbf7c62c740(0000) GS:ffff8c5badc00000(0000) knlGS:0000000000000000 > > [11381.854195] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > [11381.854197] CR2: 000055a38b7793f8 CR3: 0000000363e1e001 CR4: 00000000003726e0 > > [11381.854200] DR0: ffffffffb3407980 DR1: 0000000000000000 DR2: 0000000000000000 > > [11381.854202] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 > > [11381.854204] Call Trace: > > [11381.854207] > > [11381.854212] s_module_exit+0xc/0xff0 [symbol_getput] > > [11381.854219] __do_sys_delete_module.constprop.0+0x198/0x2f0 > > [11381.854225] do_syscall_64+0x58/0x80 > > [11381.854231] ? exit_to_user_mode_prepare+0x180/0x1f0 > > [11381.854237] ? syscall_exit_to_user_mode+0x17/0x40 > > [11381.854241] ? do_syscall_64+0x67/0x80 > > [11381.854245] ? syscall_exit_to_user_mode+0x17/0x40 > > [11381.854248] ? do_syscall_64+0x67/0x80 > > [11381.854252] ? exc_page_fault+0x70/0x170 > > [11381.854256] entry_SYSCALL_64_after_hwframe+0x72/0xdc > > > > Signed-off-by: Rong Tao > > Reviewed-by: Petr Mladek Applied and pushed, as this is just samples/ directory I won't send right away to Linus as its not that critical. Luis