From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEC4DC001DE for ; Thu, 13 Jul 2023 16:49:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235329AbjGMQt0 (ORCPT ); Thu, 13 Jul 2023 12:49:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235409AbjGMQtL (ORCPT ); Thu, 13 Jul 2023 12:49:11 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E277130F2; Thu, 13 Jul 2023 09:48:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689266936; x=1720802936; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=59+LYzhy+0HnTxIOhHyvr1lUJNvrJlPI3qg9viatPhw=; b=RsSn98qNzo36YDz8LB9gE/UYTT+FNCd8p1PdHEz3NhgigiWapiBGy9jw XjIh9jECFZVM5pyuPgBhtqoytUGm5YZJUe7eF3Jh1ZsP3DzAlPXdXmKL6 AXltNhTjtY6cqRwneDaSI70OzVYUgISWvp6gOeQfCDnK6VbbB8o02yEnm 7JsqSroTBPbL+WJnqbeGoUM5+YyDtMfc3qnHlNlyQny4crYxRh5Qmal7b jdCpTOVd+utwYDnFBAxjeXXH56aCLmXWWEA+ddc/vM7YNywYh5AbE+eyc d9cI+ykItg9m5gK6ra5UfYFlqp5F7AMfGnYnxGCXxrZIazFcboAG43sxX A==; X-IronPort-AV: E=McAfee;i="6600,9927,10770"; a="365286096" X-IronPort-AV: E=Sophos;i="6.01,203,1684825200"; d="scan'208";a="365286096" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2023 09:48:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10770"; a="787520642" X-IronPort-AV: E=Sophos;i="6.01,203,1684825200"; d="scan'208";a="787520642" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga008.fm.intel.com with ESMTP; 13 Jul 2023 09:48:54 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qJzUr-002RPD-1P; Thu, 13 Jul 2023 19:48:53 +0300 Date: Thu, 13 Jul 2023 19:48:53 +0300 From: Andy Shevchenko To: Srinivas Pandruvada Cc: hdegoede@redhat.com, markgross@kernel.org, ilpo.jarvinen@linux.intel.com, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/3] TPMI control and debugfs support Message-ID: References: <20230712225950.171326-1-srinivas.pandruvada@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230712225950.171326-1-srinivas.pandruvada@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 12, 2023 at 03:59:47PM -0700, Srinivas Pandruvada wrote: > The first patch provides interface to read feature status. This is > generic patch to be used by other feature drivers. > > The second patch add support for debugfs. Debugfs also display > feature status using the first patch Reviewed-by: Andy Shevchenko A couple of nit-picks in the individual comments. > Srinivas Pandruvada (3): > platform/x86/intel/tpmi: Read feature control status > platform/x86/intel/tpmi: Add debugfs interface > doc: TPMI: Add debugfs documentation > > Documentation/ABI/testing/debugfs-tpmi | 31 ++ > MAINTAINERS | 1 + > drivers/platform/x86/intel/tpmi.c | 399 ++++++++++++++++++++++++- > include/linux/intel_tpmi.h | 2 + > 4 files changed, 426 insertions(+), 7 deletions(-) > create mode 100644 Documentation/ABI/testing/debugfs-tpmi > > -- > 2.40.1 > -- With Best Regards, Andy Shevchenko