From: Petr Mladek <pmladek@suse.com>
To: huzhi001@208suo.com
Cc: tglx@linutronix.de, senozhatsky@chromium.org,
adobriyan@gmail.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] proc: Fix four errors in kmsg.c
Date: Fri, 14 Jul 2023 10:31:32 +0200 [thread overview]
Message-ID: <ZLEH5AQKsfLfSxV7@alley> (raw)
In-Reply-To: <ZLEF16qgcTOaLMIk@alley>
On Fri 2023-07-14 10:22:48, Petr Mladek wrote:
> On Fri 2023-07-14 14:57:59, huzhi001@208suo.com wrote:
> > The following checkpatch errors are removed:
> > ERROR: "foo * bar" should be "foo *bar"
> > ERROR: "foo * bar" should be "foo *bar"
> > ERROR: "foo * bar" should be "foo *bar"
> > ERROR: "foo * bar" should be "foo *bar"
>
> Please, do not do fix these cosmetic issues reported by checkpatch.pl.
> It is not worth the effort. In fact, it is contra productive.
> It complicates the git history, backports.
BTW, Did anyone suggest you to fix errors/warnings reported by
checkpatch.pl?
You seem to be 2nd person who sent similar patch from @suo.com
within the last week. The first patch was rejected as well,
see
https://lore.kernel.org/all/f2d8eb955890bc1db1b307db713d4a4a@208suo.com/
You might want to tell this person that there are better ways
how to get involved into the kernel development.
Best Regards,
Petr
next prev parent reply other threads:[~2023-07-14 8:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tencent_053A1A860EFB7AAD92B2409B9D5AE06AB507@qq.com>
2023-07-14 6:57 ` huzhi001
2023-07-14 8:22 ` Petr Mladek
2023-07-14 8:31 ` Petr Mladek [this message]
2023-07-17 6:05 ` Sergey Senozhatsky
2023-07-17 6:08 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLEH5AQKsfLfSxV7@alley \
--to=pmladek@suse.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=huzhi001@208suo.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=senozhatsky@chromium.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®