From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E562C04A94 for ; Fri, 14 Jul 2023 08:44:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235425AbjGNIof (ORCPT ); Fri, 14 Jul 2023 04:44:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234967AbjGNIo3 (ORCPT ); Fri, 14 Jul 2023 04:44:29 -0400 Received: from 167-179-156-38.a7b39c.syd.nbn.aussiebb.net (167-179-156-38.a7b39c.syd.nbn.aussiebb.net [167.179.156.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F08752708; Fri, 14 Jul 2023 01:44:19 -0700 (PDT) Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1qKEPL-001Rcz-AL; Fri, 14 Jul 2023 18:44:12 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 14 Jul 2023 18:44:04 +1000 Date: Fri, 14 Jul 2023 18:44:04 +1000 From: Herbert Xu To: Jia Jie Ho Cc: "David S . Miller" , linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org Subject: Re: [PATCH] crypto: starfive - Add AES skcipher and aead support Message-ID: References: <20230706032737.424378-1-jiajie.ho@starfivetech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230706032737.424378-1-jiajie.ho@starfivetech.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 06, 2023 at 11:27:37AM +0800, Jia Jie Ho wrote: > Adding AES skcipher and aead support to Starfive crypto module. > Skcipher modes of operation include ecb, cbc, ctr, ofb, cfb. Aead modes > include ccm and gcm. > > Co-developed-by: Huan Feng > Signed-off-by: Huan Feng > Signed-off-by: Jia Jie Ho > --- > drivers/crypto/starfive/Kconfig | 2 + > drivers/crypto/starfive/Makefile | 2 +- > drivers/crypto/starfive/jh7110-aes.c | 1034 +++++++++++++++++++++++++ > drivers/crypto/starfive/jh7110-cryp.c | 36 +- > drivers/crypto/starfive/jh7110-cryp.h | 64 ++ > 5 files changed, 1131 insertions(+), 7 deletions(-) > create mode 100644 drivers/crypto/starfive/jh7110-aes.c This doesn't compile: CC [M] drivers/crypto/starfive/jh7110-cryp.o CC [M] drivers/crypto/starfive/jh7110-hash.o CC [M] drivers/crypto/starfive/jh7110-rsa.o CC [M] drivers/crypto/starfive/jh7110-aes.o In file included from ../drivers/crypto/starfive/jh7110-aes.c:13: ../drivers/crypto/starfive/jh7110-cryp.h:184:49: error: field ‘aes_done’ has incomplete type 184 | struct tasklet_struct aes_done; | ^~~~~~~~ ../drivers/crypto/starfive/jh7110-cryp.h:185:49: error: field ‘hash_done’ has incomplete type 185 | struct tasklet_struct hash_done; | ^~~~~~~~~ make[6]: *** [../scripts/Makefile.build:243: drivers/crypto/starfive/jh7110-aes.o] Error 1 make[6]: *** Waiting for unfinished jobs.... Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt